perf: avoid throw-as-control-flow in SessionManager hot path (#7756) #7224
Annotations
1 error, 1 warning, and 1 notice
|
[chromium-admin] › tests/frontend-new/admin-spec/adminsettings.spec.ts:127:7 › admin settings › form view derives label + help text from key comment:
src/tests/frontend-new/admin-spec/adminsettings.spec.ts#L152
1) [chromium-admin] › tests/frontend-new/admin-spec/adminsettings.spec.ts:127:7 › admin settings › form view derives label + help text from key comment
Error: expect(locator).toContainText(expected) failed
Locator: locator('label[for="field-title"]').locator('xpath=ancestor::*[contains(@Class,"settings-row")][1]')
Expected substring: "CustomTitleLabel"
Received string: "Name your instance!"
Timeout: 20000ms
Call log:
- Expect "toContainText" with timeout 20000ms
- waiting for locator('label[for="field-title"]').locator('xpath=ancestor::*[contains(@Class,"settings-row")][1]')
44 × locator resolved to <div class="settings-row" id="settings-row-title">…</div>
- unexpected value "Name your instance!"
150 | await expect(titleLabel).toBeVisible({timeout: 10000});
151 | const titleRow = titleLabel.locator('xpath=ancestor::*[contains(@Class,"settings-row")][1]');
> 152 | await expect(titleRow).toContainText('CustomTitleLabel');
| ^
153 | await expect(titleRow).toContainText('ExtraHelpMarker');
154 |
155 | // Restore
at /home/runner/work/etherpad/etherpad/src/tests/frontend-new/admin-spec/adminsettings.spec.ts:152:28
|
|
with plugins (25)
No files were found with the provided path: src/playwright-report/. No artifacts will be uploaded.
|
|
🎭 Playwright Run Summary
1 flaky
[chromium-admin] › tests/frontend-new/admin-spec/adminsettings.spec.ts:127:7 › admin settings › form view derives label + help text from key comment
43 passed (1.2m)
|