Conversation
|
✅Static analysis result - no issues found! ✅ |
finger563
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a WiFi configuration CLI for easier device programming and reconfiguration, along with various refactors to support improved RTSP client handling and build workflows. Key changes include updating ESP32 dependencies, refactoring main.cpp to integrate the CLI and related tasks, and modifying the CI workflow to build executables for both ESP-BOX and T-Deck targets.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdkconfig.defaults.{t-deck, esp32s3, esp-box} | Added hardware-specific config definitions. |
| sdkconfig.defaults | Enabled C++ exceptions for the CLI library. |
| main/main.cpp | Refactored main logic to include CLI support, RTSP client/task handling, and display functions. |
| main/Kconfig.projbuild | Updated WiFi credentials’ defaults. |
| README.md | Expanded documentation with a table of contents and CLI usage instructions. |
| .github/workflows/package_main.yml | Revised build matrix to support per-target build commands. |
Comments suppressed due to low confidence (2)
main/main.cpp:51
- The 'task_notified' parameter controls task termination in the callback, but its initialization or expected state isn’t clearly visible. Ensure that 'task_notified' is properly set before scheduling the RTSP client task to avoid unintended behavior.
bool start_rtsp_client(std::mutex &m, std::condition_variable &cv, bool &task_notified);
.github/workflows/package_main.yml:20
- Matrix build entries no longer specify a 'command' field, which leads to an empty command in the build step. Consider adding the appropriate build command for each target (e.g. 'idf.py -DSDKCONFIG_DEFAULTS="sdkconfig.defaults;sdkconfig.esp-box" build').
- name: 'esp-box'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Allows users to more easily program / use / reconfigure without having to compile code.
How has this been tested?
Build and run
mainon esp-box.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.