Merge pull request #1988 from davidBar-On/issue-1984-UDP-0-loss-despite-non-zero-loss

Fix backward compatibility issue of client incorrectly print 0 UDP packets loss

Author: bmah888

src/iperf_api.c

@@ -2817,7 +2817,9 @@ get_results(struct iperf_test *test)
     cJSON *j_server_output;
     cJSON *j_start_time, *j_end_time;
     int sid;
-    int64_t cerror, pcount, omitted_cerror, omitted_pcount;
+    int64_t cerror, pcount;
+    // Init as seems to not be au-initialized to 0 by default, maybe because later init is only under if statement
+    int64_t omitted_cerror = 0, omitted_pcount = 0;
     double jitter;
     iperf_size_t bytes_transferred;
     int retransmits;
@@ -4374,7 +4376,9 @@ iperf_print_results(struct iperf_test *test)
                      * data here.
                      */
                     if (! test->json_output) {
-                        if (receiver_packet_count - receiver_omitted_packet_count > 0 && sp->omitted_cnt_error > -1) {
+                        if (test->omit == 0 && receiver_packet_count > 0) {
+                            lost_percent = 100.0 * sp->cnt_error / receiver_packet_count;
+                        } else if (receiver_packet_count - receiver_omitted_packet_count > 0 && sp->omitted_cnt_error > -1) {
                             lost_percent = 100.0 * (sp->cnt_error - sp->omitted_cnt_error) / (receiver_packet_count - receiver_omitted_packet_count);
                         }
                         else {
@@ -4386,7 +4390,9 @@ iperf_print_results(struct iperf_test *test)
                                 iperf_printf(test, report_receiver_not_available_format, sp->socket);
                         }
                         else {
-                            if (sp->omitted_cnt_error > -1) {
+                            if (test->omit == 0) {
+                                iperf_printf(test, report_bw_udp_format, sp->socket, mbuf, start_time, receiver_time, ubuf, nbuf, sp->jitter * 1000.0, sp->cnt_error, receiver_packet_count, lost_percent, report_receiver);
+                            } else if (sp->omitted_cnt_error > -1) {
                                 iperf_printf(test, report_bw_udp_format, sp->socket, mbuf, start_time, receiver_time, ubuf, nbuf, sp->jitter * 1000.0, (sp->cnt_error - sp->omitted_cnt_error), (receiver_packet_count - receiver_omitted_packet_count), lost_percent, report_receiver);
                             } else {
                                 iperf_printf(test, report_bw_udp_format_no_omitted_error, sp->socket, mbuf, start_time, receiver_time, ubuf, nbuf, sp->jitter * 1000.0, (receiver_packet_count - receiver_omitted_packet_count), report_receiver);