Fix smspec_node operators

The operators would throw a TypeError before this fix, but now they
follow the usual conventions of returning NotImplemented.

Author: eivindjahren

lib/include/resdata/smspec_node.hpp

@@ -117,6 +117,16 @@ class smspec_node {
         return node1->cmp(*node2);
     }
 
+    bool operator==(const smspec_node &other) const {
+        return this->cmp(other) == 0;
+    }
+    bool operator<(const smspec_node &other) const {
+        return this->cmp(other) < 0;
+    }
+    bool operator>(const smspec_node &other) const {
+        return this->cmp(other) > 0;
+    }
+
     int get_R1() const;
     int get_R2() const;
     const char *get_gen_key1() const;

lib/resdata/smspec_node_pybind.cpp

@@ -1,3 +1,4 @@
+#include <pybind11/operators.h>
 #include <pybind11/pybind11.h>
 #include <pybind11/stl.h>
 
@@ -16,13 +17,6 @@ py::object SummaryVarType() {
     return cls;
 }
 
-int node_cmp(const rd::smspec_node &self, py::handle other) {
-    if (!py::isinstance<rd::smspec_node>(other))
-        throw py::type_error(
-            "Other argument must be of type ResdataSMSPECNode");
-    return self.cmp(other.cast<const rd::smspec_node &>());
-}
-
 } // namespace
 
 PYBIND11_MODULE(rd_smspec_node, m) {
@@ -32,19 +26,9 @@ PYBIND11_MODULE(rd_smspec_node, m) {
                           "Class can not be instantiated directly!");
             throw py::error_already_set();
         }))
-        .def("cmp", &node_cmp, py::arg("other"))
-        .def("__lt__",
-             [](const rd::smspec_node &self, py::handle other) {
-                 return node_cmp(self, other) < 0;
-             })
-        .def("__gt__",
-             [](const rd::smspec_node &self, py::handle other) {
-                 return node_cmp(self, other) > 0;
-             })
-        .def("__eq__",
-             [](const rd::smspec_node &self, py::handle other) {
-                 return node_cmp(self, other) == 0;
-             })
+        .def(py::self == py::self)
+        .def(py::self < py::self)
+        .def(py::self > py::self)
         .def("__hash__",
              [](const rd::smspec_node &self) {
                  return py::hash(py::cast(self.get_gen_key1()));

tests/rd_tests/test_rd_sum.py

@@ -280,6 +280,50 @@ def test_that_non_matching_dataframe_gives_empty_columns(summary):
     )
 
 
+@given(summaries())
+@pytest.mark.usefixtures("use_tmpdir")
+def test_that_equal_smspec_nodes_have_equal_hash(summary):
+    """The __hash__/__eq__ contract requires that a == b implies
+    hash(a) == hash(b) for all smspec_nodes of a summary case."""
+    smspec, unsmry = summary
+    assume(len(smspec.keywords) == len(set(smspec.keywords)))
+    smspec.to_file("TEST.SMSPEC")
+    unsmry.to_file("TEST.UNSMRY")
+    summary = Summary("TEST", lazy_load=False)
+
+    nodes = [summary.smspec_node(key) for key in summary.keys()]
+    for node1, node2 in itertools.product(nodes, repeat=2):
+        if node1 == node2:
+            assert hash(node1) == hash(node2)
+
+
+@given(summaries())
+@pytest.mark.usefixtures("use_tmpdir")
+def test_that_smspec_node_comparison_with_other_types_is_consistent(summary):
+    """Comparing a smspec_node to an object of another type should never
+    consider them equal, and ordering comparisons should raise TypeError,
+    matching normal Python semantics for unsupported comparisons."""
+    smspec, unsmry = summary
+    assume(len(smspec.keywords) == len(set(smspec.keywords)))
+    assume(len(smspec.keywords) > 0)
+    smspec.to_file("TEST.SMSPEC")
+    unsmry.to_file("TEST.UNSMRY")
+    summary = Summary("TEST", lazy_load=False)
+
+    node = summary.smspec_node(next(iter(summary.keys())))
+
+    assert node != "a_string"
+    assert not (node == 5)
+    assert node is not None
+    assert node != None  # noqa: E711
+
+    with pytest.raises(TypeError):
+        node < "a_string"
+
+    with pytest.raises(TypeError):
+        node > 5
+
+
 def create_summary(
     summary_keys=("FOPR",),
     time_units="DAYS",