Fix a bug where SummaryKeyWordVector outlived its Summary

Author: eivindjahren

python/resdata/summary/rd_sum_keyword_vector.py

@@ -13,6 +13,7 @@ class SummaryKeyWordVector(BaseCClass):
 
     def __init__(self, rd_sum, add_keywords=False):
         c_pointer = _rd_sum_keyword_vector._alloc(rd_sum, add_keywords)
+        self._rd_sum = rd_sum
         super().__init__(c_pointer)
 
     def __getitem__(self, index):
@@ -42,6 +43,8 @@ def __repr__(self):
         return self._create_repr("len=%d" % len(self))
 
     def copy(self, rd_sum):
-        return SummaryKeyWordVector.createPythonObject(
+        cpy = SummaryKeyWordVector.createPythonObject(
             _rd_sum_keyword_vector._alloc_copy(self, rd_sum)
         )
+        cpy._rd_sum = rd_sum
+        return cpy

tests/rd_tests/test_sum.py

@@ -1,5 +1,6 @@
 import csv
 import datetime
+import gc
 import os
 import os.path
 import shutil
@@ -873,3 +874,23 @@ def test_that_end_time_is_sim_start_when_there_are_no_steps():
     assert summary.end_date == summary.start_date
     # Note that in this situation
     # sum.data_start will raise
+
+
+def test_that_summary_keyword_vector_lifetime_is_longer_than_summary():
+    """A regression test for a bug where SummaryKeyWordVector outlived its Summary"""
+
+    def _create():
+        summary = createSummary(
+            "CASE",
+            [("FOPR", None, 0, "SM3")],
+            sim_length_days=100,
+            num_report_step=0,
+            num_mini_step=0,
+            sim_start=datetime.date(2010, 1, 1),
+            func_table={},
+        )
+        return SummaryKeyWordVector(summary)
+
+    vector = _create()
+    gc.collect()
+    vector.add_keywords("FOPR")