Fix warnings in Elixir 1.20 and require Elixir 1.15 (#474)

Author: sabiwara

.github/workflows/main.yml

@@ -24,7 +24,7 @@ jobs:
             elixir: "1.18"
           # Oldest version. We technically support OTP 23 but hard to test in CI
           - erlang: "24.3"
-            elixir: "1.14"
+            elixir: "1.15"
 
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

lib/mint/core/transport/ssl.ex

@@ -1,7 +1,6 @@
 defmodule Mint.Core.Transport.SSL do
   @moduledoc false
 
-  require Logger
   require Record
 
   @behaviour Mint.Core.Transport

lib/mint/http1.ex

@@ -762,7 +762,7 @@ defmodule Mint.HTTP1 do
         {:ok, conn, responses}
 
       length <= byte_size(data) ->
-        <<body::binary-size(length), rest::binary>> = data
+        <<body::binary-size(^length), rest::binary>> = data
         {conn, responses} = add_body(conn, body, responses)
         conn = request_done(conn)
         responses = [{:done, request_ref} | responses]
@@ -836,7 +836,7 @@ defmodule Mint.HTTP1 do
         {:ok, conn, responses}
 
       length <= byte_size(data) ->
-        <<body::binary-size(length), rest::binary>> = data
+        <<body::binary-size(^length), rest::binary>> = data
         {conn, responses} = add_body(conn, body, responses)
         conn = put_in(conn.request.body, {:chunked, :crlf})
         decode_body({:chunked, :crlf}, conn, rest, request_ref, responses)

lib/mint/http2.ex

@@ -1266,7 +1266,7 @@ defmodule Mint.HTTP2 do
   end
 
   defp split_payload_in_chunks(binary, chunk_size, acc) do
-    <<chunk::size(chunk_size)-binary, rest::binary>> = binary
+    <<chunk::size(^chunk_size)-binary, rest::binary>> = binary
     split_payload_in_chunks(rest, chunk_size, [chunk | acc])
   end
 

lib/mint/http2/frame.ex

@@ -271,7 +271,7 @@ defmodule Mint.HTTP2.Frame do
     else
       # 1 byte is for the space taken by pad_length
       data_length = byte_size(payload) - pad_length - 1
-      <<data::size(data_length)-binary, padding::size(pad_length)-binary>> = rest
+      <<data::size(^data_length)-binary, padding::size(^pad_length)-binary>> = rest
       {data, padding}
     end
   end

mix.exs

@@ -8,7 +8,7 @@ defmodule Mint.MixProject do
     [
       app: :mint,
       version: @version,
-      elixir: "~> 1.14",
+      elixir: "~> 1.15",
       start_permanent: Mix.env() == :prod,
       elixirc_paths: elixirc_paths(Mix.env()),
       deps: deps(),

test/mint/http1/conn_properties_test.exs

@@ -90,7 +90,7 @@ defmodule Mint.HTTP1.PropertiesTest do
       |> Enum.sort()
       |> Enum.reduce({[], binary, 0}, fn split, {chunks, rest, prev_split} ->
         length = split - prev_split
-        <<chunk::binary-size(length), rest::binary>> = rest
+        <<chunk::binary-size(^length), rest::binary>> = rest
         {[chunk | chunks], rest, split}
       end)
       |> join_last_chunk()

test/mint/http2/integration_test.exs

@@ -37,11 +37,9 @@ defmodule HTTP2.IntegrationTest do
 
     assert {:ok, %HTTP2{} = conn, ref} = HTTP2.request(conn, "GET", "/httpbin/", [], nil)
 
-    # For some reason, on OTP 26+ we get an SSL message sneaking in here. Instead of going
+    # For some reason, we get an SSL message sneaking in here. Instead of going
     # crazy trying to debug it, for now let's just swallow it.
-    if System.otp_release() >= "26" do
-      assert_receive {:ssl, _socket, _data}, 1000
-    end
+    assert_receive {:ssl, _socket, _data}, 1000
 
     assert {:ok, %HTTP2{} = conn, responses} = receive_stream(conn)
 

test/mint/unix_socket_test.exs

@@ -3,8 +3,6 @@ defmodule Mint.UnixSocketTest do
 
   alias Mint.{HTTP, TestSocketServer}
 
-  require HTTP
-
   unix? = match?({:unix, _}, :os.type())
   otp_19? = System.otp_release() >= "19"
   @moduletag skip: not (unix? and otp_19?)