Skip to content

1.18 typing violation #1105

@mhanberg

Description

@mhanberg

Description

I haven't looked into this much, but dropping the issue before i forgot.

When compiling explorer in CI for 1.18.2, the typing warning was emitted

     warning: the following clause will never match:
         {:ok, df}
     because it attempts to match on the result of:
         from_query(conn, query, params, opts)
     which has type:
         none()
     typing violation found at:
     │
 520 │       {:ok, df} -> df
     │       ~~~~~~~~~~~~~~~
     │
     └─ lib/explorer/data_frame.ex:520: Explorer.DataFrame.from_query!/4
     warning: the following clause will never match:
         {:error, error}
     because it attempts to match on the result of:
         from_query(conn, query, params, opts)
     which has type:
         none()
     typing violation found at:
     │
 521 │       {:error, error} -> raise error
     │       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     │
     └─ lib/explorer/data_frame.ex:521: Explorer.DataFrame.from_query!/4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions