Add tests for --no-timezone

Author: josevalim

lib/mix/tasks/ecto.create.ex

@@ -9,6 +9,7 @@ defmodule Mix.Tasks.Ecto.Create do
     repo: [:string, :keep],
     no_compile: :boolean,
     no_deps_check: :boolean,
+    no_timezone: :boolean,
     timezone: :string
   ]
 
@@ -60,6 +61,13 @@ defmodule Mix.Tasks.Ecto.Create do
         "create storage for #{inspect(repo)}"
       )
 
+      opts =
+        if Keyword.get(opts, :no_timezone) do
+          Keyword.put(opts, :timezone, nil)
+        else
+          opts
+        end
+
       config_opts = Keyword.take(opts, [:timezone]) ++ repo.config()
 
       case repo.__adapter__().storage_up(config_opts) do

test/mix/tasks/ecto.create_drop_test.exs

@@ -64,13 +64,15 @@ defmodule Mix.Tasks.Ecto.CreateDropTest do
   end
 
   test "parses options" do
-    Process.put(:storage_up, :ok)
-    Create.run(["-r", to_string(Repo)])
-    refute Keyword.has_key?(Process.get(:storage_up), :timezone)
+    run_options = fn args ->
+      Process.put(:storage_up, :ok)
+      Create.run(["-r", to_string(Repo)] ++ args)
+      Keyword.take(Process.get(:storage_up), [:timezone])
+    end
 
-    Process.put(:storage_up, :ok)
-    Create.run(["-r", to_string(Repo), "--timezone", "Europe/Warsaw"])
-    assert Keyword.take(Process.get(:storage_up), [:timezone]) == [timezone: "Europe/Warsaw"]
+    refute Keyword.has_key?(run_options.([]), :timezone)
+    assert run_options.(["--no-timezone"]) == [timezone: nil]
+    assert run_options.(["--timezone", "Europe/Warsaw"]) == [timezone: "Europe/Warsaw"]
   end
 
   test "runs the adapter storage_up with --quiet" do