chore: PR feedabck, include index in query cache key

Author: zachdaniel

lib/ecto/adapter/queryable.ex

@@ -105,13 +105,7 @@ defmodule Ecto.Adapter.Queryable do
     %{adapter: adapter, cache: cache} = Ecto.Repo.Registry.lookup(repo_name_or_pid)
 
     counter = Keyword.get(opts, :counter, 0)
-
-    query_cache? =
-      if counter != 0 do
-        false
-      else
-        Keyword.get(opts, :query_cache, true)
-      end
+    query_cache? = Keyword.get(opts, :query_cache, true)
 
     {_meta, prepared, _cast_params, dump_params} =
       queryable

lib/ecto/query/planner.ex

@@ -136,7 +136,14 @@ defmodule Ecto.Query.Planner do
   def query(query, operation, cache, adapter, counter, query_cache?) do
     {query, params, key} = plan(query, operation, adapter)
     {cast_params, dump_params} = Enum.unzip(params)
-    key = if query_cache?, do: key, else: :nocache
+
+    key =
+      cond do
+        not query_cache? -> :nocache
+        counter != 0 -> {key, counter}
+        true -> key
+      end
+
     query_with_cache(key, query, operation, cache, adapter, counter, cast_params, dump_params)
   end