When "Hide from search results" is enabled for post_type/taxonomy: don't add "Meta title", "Meta desc." and "Index" columns admin list view

[joostdekeijzer]

Currently even when "Hide from search results" is enabled in the Slim SEO settings, the columns "Meta title", "Meta desc." and "Index" columns are added to the Admin list views.

The seem unnecessary?

A simple modification of Post.php and Term.php makes adding the columns follow the Slim SEO settings, eg. (after adding use SlimSEO\Helpers\Option; at the top)

	public function setup_admin() {
		parent::setup_admin();

		foreach ( $this->types as $type ) {
			if ( ! Option::get( "{$type}.noindex", false ) ) {
				add_filter( "manage_{$type}_posts_columns", [ $this, 'columns' ] );
				add_action( "manage_{$type}_posts_custom_column", [ $this, 'render' ], 10, 2 );
			}
		}
	}

I can create a PR if you want.

Related would be not showing the "Search Engine Optimization" block on the item page.

[rilwis]

Hi @joostdekeijzer ,

Thanks for your feedback. I'm wondering if not adding admin columns and meta box can cause confusion to users, as they don't know why the SEO settings disappear (they might configured a long time ago in the Settings > Slim SEO).

[joostdekeijzer]

Hi @rilwis,

Confusion might be possible but those columns are "unnecessary" as the content is never output? I myself have the confusion the other way around: why are those columns there when I've disabled Slim SEO for those types/taxonomies...

My issue is also that in my (client) projects I have quite some "private" CPTs with many columns. The Slim SEO columns just take up too much space there.

[rilwis]

I see. I agree with that. I'm just thinking if removing columns + meta box, is there any way to let users know if that post type (or taxonomy) is hid from search results (by the settings).

Can you please open a PR?

[joostdekeijzer]

There might be several ways to inform users. I think the least intrusive would be to keep the "index" column (with a red cross for those items) and just keep the item-page without any extra info. Not sure if I would be happy with that myself though 🙄

It looks quite straight forward to remove both the columns and the form fields. To optionally either add all columns or just the index column will make the code more complex. Especially since there is both the Slim settings and a hook (is the behaviour different if the hook changes the types/taxonomies?).

Another option might be a "notification" as below. They come in several colours and may have a "close" button.

I would suggest only showing it on the list-page, not on the item page. Regarding settings/hook it's the same as above and I suspect that it will take some extra code to remember the optional closing.

Maybe you have some other suggestions?

[joostdekeijzer]

I'm working on a PR.

For taxonomies it's straight forward to remove both columns and metabox (see joostdekeijzer@0b0d0e7).

For post_types though, the metabox is added in vendor code from slim-seo-common (https://github.com/elightup/slim-seo-common/blob/a8ed60c7b90c2c422491c7a98ce76c67669e437c/src/Settings/Post.php#L27 specifically). That method also seems to have duplicate code (eg. getting all types is also implemented in slim-seo-common Helpers/Data).
How would you like me to handle this? Move code from common to plugin, move code from plugin to common or use the hooks?

[rilwis]

Done in #268