Modal 'Reconnecting' on any network change

[dbkr]

Steps to reproduce

1. Be in a call on a wired network
2. Turn wifi off, or on, or change wifi networks, or plug in or unplug an iphone, or anything that causes a network interface to be added or removed

Outcome

What did you expect?

Call continues uninterrupted (it was using the wired connection which hasn't gone anywhere)

What happened instead?

I'm cut off from the call and have a little modal 'reconnecting' pill over the UI for anywhere up to a few seconds.

Operating system

macOS

Browser information

No response

URL for webapp

No response

Will you send logs?

No

[toger5]

Can you confirm, that you do not use the new network interface?
Otherwise this sounds like expected behaviour.

Whats your theory that triggers the reconnect overlay?

[dbkr]

Yep, this happens when just plugging in or unplugging my iPhone (because it will do USB tethering and so counts as a network interface) but I'm definitely not using my phone's tethering when in my house.

I'm assuming that it's restarting ICE whenever network interfaces change, which is reasonable since a better route might have appeared (eg. if I plugged in a wired connection or joined wifi when I only had cellular previously) but I think it should continue using the same candidate pair it was using before so the call can continue while ICE happens rather than interrupting the call.

[Half-Shot]

I've been trying to find the proper issue for this but it reminded me of a bug in chrom(ium) where if you have a network change, it drops all your connections until it reconfigures itself (https://issues.chromium.org/issues/41465264 but I'm sure there is a more generic issue for this).

It may not be ICE but possibly our delayed event requests failing enough times to cause the Reconnect to appear?