add target in case there is no host in target#2225
Open
ajaygupta2790 wants to merge 8 commits intoelastic:mainfrom
Open
add target in case there is no host in target#2225ajaygupta2790 wants to merge 8 commits intoelastic:mainfrom
ajaygupta2790 wants to merge 8 commits intoelastic:mainfrom
Conversation
Member
|
Thanks, care to add a test too please? |
Contributor
Author
|
test case file is missing for grpc, need some suggestions on where to start @xrmx |
…t-python into grpc-target-fix-1
xrmx
reviewed
Jul 10, 2025
Comment on lines
+47
to
+48
| from tests.instrumentation.test_pb2 import UnaryUnaryRequest, UnaryUnaryResponse | ||
| from tests.instrumentation.test_pb2_grpc import TestServiceServicer, TestServiceStub, add_TestServiceServicer_to_server |
Member
There was a problem hiding this comment.
These modules should be renamed otherwise test runners think these contains tests and runs them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current grpc instrumentation expects host value with a port that may not always be true. In our project, we usean internal host without a port value
This results in span showing None value and we cannot track the external host value. All grpc hosts are clubbed together under https://none/ value
The proposal is to keep the target value as is in case there is no ':' in the host and keep the port as None