(#154) Api: avoid invalid XML comments

Author: ForNeVeR

TdLib.Api/Functions/CancelPasswordReset.cs

@@ -10,7 +10,7 @@ namespace TdLib
     public static partial class TdApi
     {
         /// <summary>
-        /// Cancels reset of 2-step verification password. The method can be called if passwordState.pending_reset_date > 0
+        /// Cancels reset of 2-step verification password. The method can be called if passwordState.pending_reset_date &gt; 0
         /// </summary>
         public class CancelPasswordReset : Function<Ok>
         {
@@ -30,7 +30,7 @@ public class CancelPasswordReset : Function<Ok>
         }
 
         /// <summary>
-        /// Cancels reset of 2-step verification password. The method can be called if passwordState.pending_reset_date > 0
+        /// Cancels reset of 2-step verification password. The method can be called if passwordState.pending_reset_date &gt; 0
         /// </summary>
         public static Task<Ok> CancelPasswordResetAsync(
             this Client client)

TdLib.Api/Functions/CreateNewStickerSet.cs

@@ -41,7 +41,7 @@ public class CreateNewStickerSet : Function<StickerSet>
             public string Title { get; set; }
 
             /// <summary>
-            /// Sticker set name. Can contain only English letters, digits and underscores. Must end with *"_by_<bot username>"* (*<bot_username>* is case insensitive) for bots; 1-64 characters
+            /// Sticker set name. Can contain only English letters, digits and underscores. Must end with *"_by_&lt;bot username&gt;"* (*&lt;bot_username&gt;* is case insensitive) for bots; 1-64 characters
             /// </summary>
             [JsonConverter(typeof(Converter))]
             [JsonProperty("name")]

TdLib.Api/Objects/PageBlockCaption.cs

@@ -33,7 +33,7 @@ public partial class PageBlockCaption : Object
             public RichText Text { get; set; }
 
             /// <summary>
-            /// Block credit (like HTML tag <cite>)
+            /// Block credit (like HTML tag &lt;cite&gt;)
             /// </summary>
             [JsonConverter(typeof(Converter))]
             [JsonProperty("credit")]

TdLib.Api/Objects/PhoneNumberAuthenticationSettings.cs

@@ -47,7 +47,7 @@ public partial class PhoneNumberAuthenticationSettings : Object
             public bool IsCurrentPhoneNumber { get; set; }
 
             /// <summary>
-            /// For official applications only. True, if the application can use Android SMS Retriever API (requires Google Play Services >= 10.2) to automatically receive the authentication code from the SMS. See https://developers.google.com/identity/sms-retriever/ for more details
+            /// For official applications only. True, if the application can use Android SMS Retriever API (requires Google Play Services &gt;= 10.2) to automatically receive the authentication code from the SMS. See https://developers.google.com/identity/sms-retriever/ for more details
             /// </summary>
             [JsonConverter(typeof(Converter))]
             [JsonProperty("allow_sms_retriever_api")]

TdLib.Api/Objects/SecretChat.cs

@@ -61,7 +61,7 @@ public partial class SecretChat : Object
             public byte[] KeyHash { get; set; }
 
             /// <summary>
-            /// Secret chat layer; determines features supported by the chat partner's application. Nested text entities and underline and strikethrough entities are supported if the layer >= 101, files bigger than 2000MB are supported if the layer >= 143, spoiler and custom emoji text entities are supported if the layer >= 144
+            /// Secret chat layer; determines features supported by the chat partner's application. Nested text entities and underline and strikethrough entities are supported if the layer &gt;= 101, files bigger than 2000MB are supported if the layer &gt;= 143, spoiler and custom emoji text entities are supported if the layer &gt;= 144
             /// </summary>
             [JsonConverter(typeof(Converter))]
             [JsonProperty("layer")]

TdLib.CodeGen/Generator.fs

@@ -65,7 +65,7 @@ let generateField (def: Parser.TlDef) (field: Parser.TlField) (annotations: Pars
 
     let lines = Utils.readResource "Field.tpl"
     lines |> Seq.map (fun line ->
-        tabulation + line.Replace("$FIELD_DESCRIPTION", description)
+        tabulation + line.Replace("$FIELD_DESCRIPTION", Utils.xmlEncode description)
             .Replace("$FIELD_ATTRIBUTES", fieldAttributes)
             .Replace("$FIELD_TYPE", fieldType)
             .Replace("$FIELD_NAME", fieldName))
@@ -93,7 +93,7 @@ let generateType (def: Parser.TlDef) (annotations: Parser.TlAnnotation list) =
 
     let lines = Utils.readResource (if isObjectType then "Object.tpl" else "Union.tpl")
     lines |> Seq.map (fun line ->
-        line.Replace("$TYPE_DESCRIPTION", description)
+        line.Replace("$TYPE_DESCRIPTION", Utils.xmlEncode description)
             .Replace("$TYPE_NAME", objectTypeName)
             .Replace("$TL_TYPE_NAME", tlTypeName)
             .Replace("$BASE_TYPE_NAME", baseTypeName)
@@ -132,7 +132,7 @@ let generateFunc (def: Parser.TlDef) (annotations: Parser.TlAnnotation list) =
 
     let lines = Utils.readResource "Function.tpl"
     lines |> Seq.map (fun line ->
-        line.Replace("$FUNC_DESCRIPTION", description)
+        line.Replace("$FUNC_DESCRIPTION", Utils.xmlEncode description)
             .Replace("$FUNC_NAME", funcTypeName)
             .Replace("$TL_FUNC_NAME", tlFuncTypeName)
             .Replace("$RETURN_TYPE_NAME", returnTypeName)

TdLib.CodeGen/Utils.fs

@@ -3,6 +3,8 @@
 open System
 open System.IO
 open System.Reflection
+open System.Xml.Linq
+
 open Xunit
 
 type Case =
@@ -34,6 +36,9 @@ let readResource res = seq {
         yield reader.ReadLine()
 }
 
+let xmlEncode(str: string): string =
+    if str = "" then ""
+    else XElement("x", str).LastNode.ToString()
 
 [<Fact>]
 let ``toCamelCase converts string to upper camel case``() =
@@ -58,3 +63,15 @@ let ``readResource reads file from embedded resources``() =
     let lines = readResource "Object.tpl"
     let first = Seq.head lines
     Assert.Equal("using System;", first)
+
+[<Fact>]
+let ``xmlEncode doesn't fail for an empty string``(): unit =
+    let original = ""
+    let encoded = xmlEncode original
+    Assert.Equal("", encoded)
+
+[<Fact>]
+let ``xmlEncode encodes XML``(): unit =
+    let original = "<html> test"
+    let encoded = xmlEncode original
+    Assert.Equal("&lt;html&gt; test", encoded)