Wrong highlighting of a block in splice

[jiribenes]

The following program:

import stream
import stringbuffer

def main() =
  println("test: ${collectString { ['h', 'e', 'l', 'l', 'o'].each }}")

highlights wrongly:

I think the rough idea is to count braces inside of the splice -- maybe allow these as a separate top-level pattern that has higher priority than string interpolation, then everything might just work out ®.

Here's the relevant code:

effekt-vscode/syntaxes/effekt.tmLanguage.json

Lines 245 to 258 in e9241a1

	"stringTemplates": {
	"begin": "\\$\\{",
	"beginCaptures": {
	"0": { "name": "punctuation.definition.template-expression.begin.effekt" }
	},
	"end": "\\}",
	"endCaptures": {
	"0": { "name": "punctuation.definition.template-expression.end.effekt" }
	},
	"name": "meta.embedded.line.effekt",
	"patterns": [
	{ "include": "$self" }
	]
	},

[jiribenes]

I tried quickly something like:

       "endCaptures": {
         "0": { "name": "punctuation.definition.template-expression.end.effekt" }
       },
-      "name": "meta.embedded.line.effekt",
       "patterns": [
+        { "include": "#balancedBraces" }
+      ],
+      "name": "meta.template.expression.effekt"
+    },
+    "balancedBraces": {
+      "patterns": [
+        {
+          "begin": "\\{",
+          "beginCaptures": {
+            "0": { "name": "punctuation.section.block.begin.effekt" }
+          },
+          "end": "\\}",
+          "endCaptures": {
+            "0": { "name": "punctuation.section.block.end.effekt" }
+          },
+          "patterns": [
+            { "include": "#balancedBraces" }
+          ]
+        },
         { "include": "$self" }
       ]
     },

but it lead to more problems down the line (when you nest more) -- ultimately counting braces with regexes is fighting against windmills... 🙃