fix: qa

Author: felipemontoya

backend/openedx_ai_badges/workflows/orchestrators.py

@@ -512,6 +512,6 @@ def generate_image(self, input_data):
                 "response": badge_image_data,
                 "status": "completed",
             }
-        except Exception as e:
+        except Exception as e:      # pylint: disable=broad-exception-caught
             logger.error("Image generation failed: %s", str(e))
             return {'error': f"Image generation failed: {str(e)}", 'status': 'error'}

backend/tests/test_mit_dcc_orchestrator.py

@@ -16,16 +16,29 @@ def test_get_api_status_ollama_starting_when_models_list_empty(mock_settings, mo
     badge_resp = MagicMock(ok=True)
     ollama_resp = MagicMock(ok=True)
     ollama_resp.json.return_value = {"models": []}
-    mock_get.side_effect = [badge_resp, ollama_resp]
+    image_resp = MagicMock(ok=True)
+
+    def side_effect(url, **kwargs):
+        if "api/tags" in url:
+            return ollama_resp
+        if "badge.example" in url:
+            return badge_resp
+        if "image.example" in url:
+            return image_resp
+        return MagicMock(ok=False)
+
+    mock_get.side_effect = side_effect
 
     mock_settings.MIT_DCC_BADGE_API_HEALTH_URL = "https://badge.example/health"
     mock_settings.MIT_SLM_OLLAMA_URL = "https://ollama.example/api/generate"
     mock_settings.MIT_SLM_OLLAMA_TOKEN = "secret"
+    mock_settings.MIT_DCC_BADGE_IMAGE_API_HEALTH_URL = "https://image.example/health"
 
     result = _orchestrator().get_api_status({})
 
     assert result["services"]["badge_api"]["status"] == "online"
     assert result["services"]["ollama"]["status"] == "starting"
+    assert result["services"]["image_api"]["status"] == "online"
 
 
 @patch("openedx_ai_badges.workflows.orchestrators.requests.get")
@@ -35,16 +48,29 @@ def test_get_api_status_ollama_online_when_models_list_has_entries(mock_settings
     badge_resp = MagicMock(ok=True)
     ollama_resp = MagicMock(ok=True)
     ollama_resp.json.return_value = {"models": [{"name": "phi4-chat:latest"}]}
-    mock_get.side_effect = [badge_resp, ollama_resp]
+    image_resp = MagicMock(ok=True)
+
+    def side_effect(url, **kwargs):
+        if "api/tags" in url:
+            return ollama_resp
+        if "badge.example" in url:
+            return badge_resp
+        if "image.example" in url:
+            return image_resp
+        return MagicMock(ok=False)
+
+    mock_get.side_effect = side_effect
 
     mock_settings.MIT_DCC_BADGE_API_HEALTH_URL = "https://badge.example/health"
     mock_settings.MIT_SLM_OLLAMA_URL = "https://ollama.example/api/generate"
     mock_settings.MIT_SLM_OLLAMA_TOKEN = "secret"
+    mock_settings.MIT_DCC_BADGE_IMAGE_API_HEALTH_URL = "https://image.example/health"
 
     result = _orchestrator().get_api_status({})
 
     assert result["services"]["badge_api"]["status"] == "online"
     assert result["services"]["ollama"]["status"] == "online"
+    assert result["services"]["image_api"]["status"] == "online"
 
 
 @patch("openedx_ai_badges.workflows.orchestrators.requests.post")
@@ -55,17 +81,19 @@ def test_generate_image_success(mock_settings, mock_post):
 
     # Mock response
     mock_resp = MagicMock(ok=True)
-    mock_resp.json.return_value = {"base64": "fakebase64", "config": {"layers": []}}
+    mock_resp.json.return_value = {
+        "data": {"base64": "fakebase64"},
+        "config": {"layers": []}
+    }
     mock_post.return_value = mock_resp
 
     # Mock orchestrator and session
-    orchestrator = MITDCCBadgeOrchestrator(
-        profile=MagicMock(),
-        session=MagicMock(metadata={"complete_info": {"badge": {"name": "Test"}}}),
-        location_id="loc",
-        course_id="course",
-        user=MagicMock()
-    )
+    orchestrator = object.__new__(MITDCCBadgeOrchestrator)
+    orchestrator.profile = MagicMock()
+    orchestrator.session = MagicMock(metadata={"complete_info": {"badge": {"name": "Test"}}})
+    orchestrator.location_id = "loc"
+    orchestrator.course_id = "course"
+    orchestrator.user = MagicMock()
 
     result = orchestrator.generate_image({
         "mode": "icon_based",

frontend/src/components/AIBadgesTab/BadgePreview.tsx

@@ -93,8 +93,8 @@ const BadgePreview = ({
             {generatedBadge.badgeImage ? (
               <div className="mb-4">
                 <img
-                  src={generatedBadge.badgeImage.base64.startsWith('data:') 
-                    ? generatedBadge.badgeImage.base64 
+                  src={generatedBadge.badgeImage.base64.startsWith('data:')
+                    ? generatedBadge.badgeImage.base64
                     : `data:image/png;base64,${generatedBadge.badgeImage.base64}`}
                   alt="Generated Badge"
                   style={{ maxWidth: '300px', height: 'auto' }}

frontend/src/hooks/useBadgeGeneration.ts

@@ -8,6 +8,7 @@ import {
   BadgeSectionKey,
   BadgeWorkflowAction,
   ProfileConfig,
+  BadgeImageResult,
 } from '../types/badges';
 
 const POLL_INTERVAL_MS = 5000;
@@ -252,7 +253,8 @@ export const useBadgeGeneration = (
         } else if (result.status === 'completed' && result.response) {
           // The result contains {base64, config}
           // We update the local state with the new badge image
-          setGeneratedBadge((prev) => (prev ? { ...prev, badgeImage: result.response } : prev));
+          const badgeImage = result.response as BadgeImageResult;
+          setGeneratedBadge((prev) => (prev ? { ...prev, badgeImage } : prev));
         }
       } catch (error: unknown) {
         setGenerationError(error instanceof Error ? error.message : 'An unexpected error occurred');