Continue mirror extension versions even if one fails - #942
Merged
netomi merged 3 commits intoMay 11, 2026
Conversation
hoangphamEclipse
force-pushed
the
mirror-verified-versions
branch
from
June 13, 2024 22:14
5fe0984 to
32caeb7
Compare
Currently, the OpenVSX server stops mirroring extension version if one of the versions failed to be mirrored. This commit logs the mirror failure instead of throwing an error. Fixes eclipse-openvsx#923.
hoangphamEclipse
force-pushed
the
mirror-verified-versions
branch
from
June 14, 2024 15:06
32caeb7 to
bcad29f
Compare
Contributor
Author
|
Added an error message to log when an extension version fail to mirror. |
Contributor
|
LGTM, we should consider wrapping the jobrunr logger as described here: https://www.jobrunr.io/en/documentation/background-methods/logging-progress/#logging otherwise the specific log message only show up in the JobRunr dashboard, but not in the actual application logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the OpenVSX server stops mirroring extension version if one of the versions failed to be mirrored. This commit logs the mirror failure instead of throwing an error.
Fixes #923.