refs: #13 of() etc should be used before the ct.

static valueOf(), of() might hvae the ability to cache known values.
So they should be preferred to the String representation.

Signed-off-by: Mark Struberg <[email protected]>

Author: struberg

api/src/main/java/javax/config/spi/Converter.java

@@ -61,12 +61,14 @@
  * <p>If no explicit Converter and no built-in Converter could be found for a certain type,
  * the {@code Config} provides an <em>Implicit Converter</em>, if</p>
  * <ul>
- *     <li>The target type {@code T} has a Constructor with a String parameter, or</li>
- *     <li>The target type {@code T} has a Constructor with a CharSequence parameter, or</li>
+ *     <li>the target type {@code T} has a {@code static T of(String)} method, or</li>
+ *     <li>the target type {@code T} has a {@code static T of(CharSequence)} method, or</li>
  *     <li>the target type {@code T} has a {@code static T valueOf(String)} method, or</li>
  *     <li>the target type {@code T} has a {@code static T valueOf(CharSequence)} method, or</li>
  *     <li>the target type {@code T} has a {@code static T parse(String)} method, or</li>
  *     <li>the target type {@code T} has a {@code static T parse(CharSequence)} method, or</li>
+ *     <li>The target type {@code T} has a Constructor with a String parameter, or</li>
+ *     <li>The target type {@code T} has a Constructor with a CharSequence parameter, or</li>
  * </ul>
  *
  * <p>The lookup will be done in the order of the above list.

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWCharSequenceOf.java

@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2016-2018 Contributors to the Eclipse Foundation
+ *
+ * See the NOTICE file(s) distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * You may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.eclipse.configjsr.converters.implicit;
+
+/**
+ * Part of the implicit Converter test.
+ *
+ * Sample class which has a valueOf(String) method
+ *
+ * @author <a href="mailto:[email protected]">Mark Struberg</a>
+ */
+public class ConvTestTypeWCharSequenceOf {
+    private String val;
+
+    public ConvTestTypeWCharSequenceOf() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWCharSequenceOf(CharSequence val) {
+        this.val = "wrong" + val;
+    }
+
+    public static ConvTestTypeWCharSequenceOf of(CharSequence val) {
+        ConvTestTypeWCharSequenceOf o = new ConvTestTypeWCharSequenceOf();
+        o.val = val.toString();
+        return o;
+    }
+
+    public String getVal() {
+        return val;
+    }
+}

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWCharSequenceParse.java

@@ -28,6 +28,16 @@
 public class ConvTestTypeWCharSequenceParse {
     private String val;
 
+    public ConvTestTypeWCharSequenceParse() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWCharSequenceParse(CharSequence val) {
+        this.val = "wrong" + val;
+    }
+
     public static ConvTestTypeWCharSequenceParse parse(CharSequence val) {
         ConvTestTypeWCharSequenceParse o = new ConvTestTypeWCharSequenceParse();
         o.val = val.toString();

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWCharSequenceValueOf.java

@@ -28,6 +28,16 @@
 public class ConvTestTypeWCharSequenceValueOf {
     private String val;
 
+    public ConvTestTypeWCharSequenceValueOf() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWCharSequenceValueOf(CharSequence val) {
+        this.val = "wrong" + val;
+    }
+
     public static ConvTestTypeWCharSequenceValueOf valueOf(CharSequence val) {
         ConvTestTypeWCharSequenceValueOf o = new ConvTestTypeWCharSequenceValueOf();
         o.val = val.toString();

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWStringOf.java

@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2016-2018 Contributors to the Eclipse Foundation
+ *
+ * See the NOTICE file(s) distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * You may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.eclipse.configjsr.converters.implicit;
+
+/**
+ * Part of the implicit Converter test.
+ *
+ * Sample class which has a valueOf(String) method
+ *
+ * @author <a href="mailto:[email protected]">Mark Struberg</a>
+ */
+public class ConvTestTypeWStringOf {
+    private String val;
+
+    public ConvTestTypeWStringOf() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWStringOf(String val) {
+        this.val = "wrong" + val;
+    }
+
+    public static ConvTestTypeWStringOf of(String val) {
+        ConvTestTypeWStringOf o = new ConvTestTypeWStringOf();
+        o.val = val;
+        return o;
+    }
+
+    public String getVal() {
+        return val;
+    }
+}

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWStringParse.java

@@ -28,6 +28,17 @@
 public class ConvTestTypeWStringParse {
     private String val;
 
+
+    public ConvTestTypeWStringParse() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWStringParse(String val) {
+        this.val = "wrong" + val;
+    }
+
     public static ConvTestTypeWStringParse parse(String val) {
         ConvTestTypeWStringParse o = new ConvTestTypeWStringParse();
         o.val = val;

tck/src/main/java/org/eclipse/configjsr/converters/implicit/ConvTestTypeWStringValueOf.java

@@ -28,6 +28,16 @@
 public class ConvTestTypeWStringValueOf {
     private String val;
 
+    public ConvTestTypeWStringValueOf() {
+    }
+
+    /**
+     * this ct should actually not be used by our test
+     */
+    public ConvTestTypeWStringValueOf(String val) {
+        this.val = "wrong" + val;
+    }
+
     public static ConvTestTypeWStringValueOf valueOf(String val) {
         ConvTestTypeWStringValueOf o = new ConvTestTypeWStringValueOf();
         o.val = val;