Rewrite "New Wizard" Swing tests to no longer require the SWTBot runner#1350
Merged
Rewrite "New Wizard" Swing tests to no longer require the SWTBot runner#1350
Conversation
ptziegler
force-pushed
the
rewrite-swtbot-swing-test
branch
7 times, most recently
from
98999ef to
a98c751
Compare
Contributor
Author
|
The error seems to be similar to #1344, expect that it can it appears on all platforms and can be reproduced locally. JDT seems to be doing some very weird stuff, because the created compilation unit is not using the source string we passed as an argument. Perhaps some there is a cache that went stale? |
ptziegler
force-pushed
the
rewrite-swtbot-swing-test
branch
2 times, most recently
from
8ceaf81 to
8686f28
Compare
ptziegler
force-pushed
the
rewrite-swtbot-swing-test
branch
3 times, most recently
from
f16acc9 to
cfc49d8
Compare
Newer Eclipse versions no longer launch a workspace when running a test outside the UI thread. Because this is a requirement for all of our SWTBot tests, we can no longer run them locally. The tests were originally written like that because they open a modal dialog and would thus lead to a deadlock if the test is also executed within the UI thread. But thanks to the changes to the `UiContext`, we have a way to make this work regardless.
ptziegler
force-pushed
the
rewrite-swtbot-swing-test
branch
from
cfc49d8 to
6722685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Eclipse versions no longer launch a workspace when running a test outside the UI thread. Because this is a requirement for all of our SWTBot tests, we can no longer run them locally.
The tests were originally written like that because they open a modal dialog and would thus lead to a deadlock if the test is also executed within the UI thread. But thanks to the changes to the
UiContext, we have a way to make this work regardless.