-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
The response is not closed after pinging the session:
Line 86 in 55813e2
| client.newCall(postRequest).execute(); |
Expected behavior
try (var response = client.newCall(request).execute()) {
// Maybe handle !response.isSuccessful()?
} catch (IOException e) {
LOGGER.info("[{}] Could not send message to extension: {}", session.getSpec().getName(), e);
}Bonus, one OkHttpClient is created per app lifecycle, not one per request:
Line 73 in 55813e2
| OkHttpClient client = new OkHttpClient().newBuilder().build(); |
Maybe log the !response.isSuccessful() case?
Cluster provider
No response
Version
No response
Additional information
Update:
Same issue in
Line 155 in 83c8f60
| client.newCall(postRequest).execute(); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working