JITServer: handle non-null compilation

When a JITServer stream failure is thrown, sometimes setting
the compilation object to NULL can be skiped to head straight
into exception handling. This causes an assert to be tripped.

In this particular case, there is a front-end call in
outOfProcessCompilationEnd (within computeDataForCHTableCommit)
which can cause a stream error. Since it isn't guarded
by a global try-catch, it results in the given
assert being tripped.

Addresses this issue:
#23845

Author: KavinSatheeskumar

runtime/compiler/control/JITServerCompilationThread.cpp

@@ -133,13 +133,20 @@ void outOfProcessCompilationEnd(TR_MethodToBeCompiled *entry, TR::Compilation *c
     std::string codeCacheStr((const char *)codeCacheHeader, codeSize);
     std::string dataCacheStr((const char *)dataCacheHeader, dataSize);
 
+    bool chTableDataValid = false;
+
     // The CH table commit data may be needed even if TR_DisableCHOpts is set,
     // because if there were bonds, it may be necessary for the client's CH
     // table commit to create unload assumptions.
     CHTableCommitData chTableData;
     if (!entry->_useAotCompilation) {
         TR_CHTable *chTable = comp->getCHTable();
-        chTableData = chTable->computeDataForCHTableCommit(comp);
+        try {
+            chTableData = chTable->computeDataForCHTableCommit(comp);
+            chTableDataValid = true;
+        } catch (JITServer::StreamFailure &e) {
+            fprintf(stderr, "JITServer stream error: %s", e.what());
+        }
     }
 
     auto classesThatShouldNotBeNewlyExtended = compInfoPT->getClassesThatShouldNotBeNewlyExtended();
@@ -214,18 +221,20 @@ void outOfProcessCompilationEnd(TR_MethodToBeCompiled *entry, TR::Compilation *c
         for (auto r : records)
             serializedRecords.push_back(std::string((const char *)r, r->size()));
 
-        entry->_stream->finishAotStoreCompilation(
-            std::string((const char *)&methodRecord->data(), methodRecord->data().size()), serializedRecords,
-            chTableData,
-            std::vector<TR_OpaqueClassBlock *>(classesThatShouldNotBeNewlyExtended->begin(),
-                classesThatShouldNotBeNewlyExtended->end()),
-            logFileStr,
-            resolvedMirrorMethodsPersistIPInfo
-                ? std::vector<TR_ResolvedJ9Method *>(resolvedMirrorMethodsPersistIPInfo->begin(),
-                      resolvedMirrorMethodsPersistIPInfo->end())
-                : std::vector<TR_ResolvedJ9Method *>(),
-            *entry->_optimizationPlan, serializedRuntimeAssumptions, memoryState, activeThreadState,
-            methodsRequiringTrampolines);
+        if (chTableDataValid) {
+            entry->_stream->finishAotStoreCompilation(
+                std::string((const char *)&methodRecord->data(), methodRecord->data().size()), serializedRecords,
+                chTableData,
+                std::vector<TR_OpaqueClassBlock *>(classesThatShouldNotBeNewlyExtended->begin(),
+                    classesThatShouldNotBeNewlyExtended->end()),
+                logFileStr,
+                resolvedMirrorMethodsPersistIPInfo
+                    ? std::vector<TR_ResolvedJ9Method *>(resolvedMirrorMethodsPersistIPInfo->begin(),
+                          resolvedMirrorMethodsPersistIPInfo->end())
+                    : std::vector<TR_ResolvedJ9Method *>(),
+                *entry->_optimizationPlan, serializedRuntimeAssumptions, memoryState, activeThreadState,
+                methodsRequiringTrampolines);
+        }
         if (TR::Options::getVerboseOption(TR_VerboseJITServer)) {
             TR_VerboseLog::writeLineLocked(TR_Vlog_JITServer,
                 "compThreadID=%d has successfully compiled AOT cache store %s memoryState=%d",
@@ -241,21 +250,23 @@ void outOfProcessCompilationEnd(TR_MethodToBeCompiled *entry, TR::Compilation *c
         comp->cg()->getConstRefInfoOnServer(constRefInfo);
 #endif
 
-        entry->_stream->finishCompilation(codeCacheStr, dataCacheStr, chTableData,
-            std::vector<TR_OpaqueClassBlock *>(classesThatShouldNotBeNewlyExtended->begin(),
-                classesThatShouldNotBeNewlyExtended->end()),
-            logFileStr,
-            resolvedMirrorMethodsPersistIPInfo
-                ? std::vector<TR_ResolvedJ9Method *>(resolvedMirrorMethodsPersistIPInfo->begin(),
-                      resolvedMirrorMethodsPersistIPInfo->end())
-                : std::vector<TR_ResolvedJ9Method *>(),
-            *entry->_optimizationPlan, serializedRuntimeAssumptions, memoryState, activeThreadState,
-            methodsRequiringTrampolines
+        if (chTableDataValid) {
+            entry->_stream->finishCompilation(codeCacheStr, dataCacheStr, chTableData,
+                std::vector<TR_OpaqueClassBlock *>(classesThatShouldNotBeNewlyExtended->begin(),
+                    classesThatShouldNotBeNewlyExtended->end()),
+                logFileStr,
+                resolvedMirrorMethodsPersistIPInfo
+                    ? std::vector<TR_ResolvedJ9Method *>(resolvedMirrorMethodsPersistIPInfo->begin(),
+                          resolvedMirrorMethodsPersistIPInfo->end())
+                    : std::vector<TR_ResolvedJ9Method *>(),
+                *entry->_optimizationPlan, serializedRuntimeAssumptions, memoryState, activeThreadState,
+                methodsRequiringTrampolines
 #if defined(J9VM_OPT_OPENJDK_METHODHANDLE)
-            ,
-            constRefInfo
+                ,
+                constRefInfo
 #endif
-        );
+            );
+        }
         if (TR::Options::getVerboseOption(TR_VerboseJITServer)) {
             TR_VerboseLog::writeLineLocked(TR_Vlog_JITServer,
                 "compThreadID=%d has successfully compiled %s memoryState=%d", compInfoPT->getCompThreadId(),