Merge pull request #146 from DunklesArchipel/source-data-fields

Fix plotting with option `original`

Author: DunklesArchipel

doc/news/source-data-fields.rst

@@ -0,0 +1,3 @@
+**Fixed:**
+
+* Fixed plotting with option `original` if the fields contain fields without units.

unitpackage/database/echemdb_entry.py

@@ -324,10 +324,24 @@ def rescale(self, units):
             {'name': 'E', 'type': 'number', 'unit': 'V', 'reference': 'RHE'},
             {'name': 'j', 'type': 'number', 'unit': 'mA / cm2'}]
 
+        Unitless fields in ``figureDescription.fields`` (e.g., ``cycle``)
+        are skipped during rescaling (For testing purposes we add here a
+        field without units to the datapackage)::
+
+            >>> entry = EchemdbEntry.create_example()
+            >>> entry.resource.custom["metadata"]["echemdb"]["figureDescription"]["fields"].append({"name": "cycle", "type": "number"})
+            >>> rescaled_entry = entry.rescale(units='original')
+            >>> rescaled_entry.fields # doctest: +NORMALIZE_WHITESPACE
+            [{'name': 't', 'type': 'number', 'unit': 's'},
+            {'name': 'E', 'type': 'number', 'unit': 'V', 'reference': 'RHE'},
+            {'name': 'j', 'type': 'number', 'unit': 'mA / cm2'}]
+
         """
         if units == "original":
             units = {
-                field["name"]: field["unit"] for field in self.figureDescription.fields
+                field["name"]: field["unit"]
+                for field in self.figureDescription.fields
+                if hasattr(field, "unit")
             }
 
         return super().rescale(units)