Discrepancy between geom_point2 and geom_point_borderless (and similar)

[bwiernik]

These functions are supposed to be aliases, but _point_borderless was updated in 05737f7 while _point2 was not. @strengejacke was that an oversight? What was the purpose of the change there — it seems like setting stroke to 0 should be the better option?

[strengejacke]

I think the _boderless() methods are broken. The idea was, iirc, to have some "separation" of the point geoms by coloring the border in the same color as the bg-color of the theme. But I think we need to add a fill argument right now, because in combination with the pch, we don't see any geoms at all. Here's a reprex that shows how the borderless-geoms should look like:

library(ggplot2)
library(see)

theme_set(theme_modern())
p1 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
   geom_point2(size = 8, alpha = 0.3)
 
p2 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
  geom_point(pch = 21, size = 8, alpha = 0.3, color = see:::.get_theme_bg_color(), fill = "black")

plots(p1, p2)

theme_set(theme_abyss())
p1 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
   geom_point2(size = 8, alpha = 0.3, color = "white")
 
p2 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
  geom_point(pch = 21, size = 8, alpha = 0.3, color = see:::.get_theme_bg_color(), fill = "white")

plots(p1, p2)

theme_set(theme_abyss())
p1 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
   geom_point2(size = 7, color = "white")
 
p2 <- ggplot(iris, aes(x = Petal.Width, y = Sepal.Length)) +
  geom_point(pch = 21, size = 7, color = see:::.get_theme_bg_color(), fill = "white")

plots(p1, p2)

^{Created on 2025-03-31 with reprex v2.1.1}

[bwiernik]

Ah, ok. When I added the "borderless" names, I meant them to be a more descriptive name for "point2" (which are borderless). If we want a geom with borders that match the background color, let's add a fixed version with a different name.

[strengejacke]

Ok, sounds good