add profiles_path variable to metadata api and service tests

Author: douglowe

tests/test_api_routes.py

@@ -141,24 +141,26 @@ def test_validate_fails_missing_elements(client: FlaskClient, crate_id: str, pay
 
 # Test POST API: /v1/ro_crates/validate_metadata
 
+# TODO: Write tests for profiles_path environment variable. This will require a refactoring of the create_app function.
 @pytest.mark.parametrize(
-    "payload, status_code, response_json",
+    "payload, status_code, response_json, profiles_path",
     [
         (
             {
                 "crate_json": '{"@context": "https://w3id.org/ro/crate/1.1/context"}',
                 "profile_name": "default"
-            }, 200, {"status": "success"}
+            }, 200, {"status": "success"}, None
         ),
         (
             {
                 "crate_json": '{"@context": "https://w3id.org/ro/crate/1.1/context"}',
-            }, 200, {"status": "success"}
+            }, 200, {"status": "success"}, None
         ),
     ],
     ids=["success_with_all_fields", "success_without_profile_name"]
 )
-def test_validate_metadata_success(client: FlaskClient, payload: dict, status_code: int, response_json: dict):
+def test_validate_metadata_success(client: FlaskClient, payload: dict, status_code: int,
+                                   response_json: dict, profiles_path: str):
     with patch("app.ro_crates.routes.post_routes.queue_ro_crate_metadata_validation_task") as mock_queue:
         mock_queue.return_value = (response_json, status_code)
 
@@ -167,7 +169,7 @@ def test_validate_metadata_success(client: FlaskClient, payload: dict, status_co
         crate_json = payload["crate_json"] if "crate_json" in payload else None
         profile_name = payload["profile_name"] if "profile_name" in payload else None
 
-        mock_queue.assert_called_once_with(crate_json, profile_name)
+        mock_queue.assert_called_once_with(crate_json, profile_name, profiles_path=profiles_path)
         assert response.status_code == status_code
         assert response.json == response_json
 

tests/test_services.py

@@ -141,32 +141,32 @@ def test_queue_ro_crate_validation_task_failure(
 # Test function: queue_ro_crate_metadata_validation_task
 
 @pytest.mark.parametrize(
-        "crate_json, profile, webhook, status_code, return_value, response_json, delay_side_effect",
+        "crate_json, profile, webhook, status_code, return_value, response_json, delay_side_effect, profiles_path",
         [
             (
                 '{"@context": "https://w3id.org/ro/crate/1.1/context"}',
                 "default", "http://webhook",
                 202, None, {"message": "Validation in progress"},
-                None
+                None, None
             ),
             (
                 '{"@context": "https://w3id.org/ro/crate/1.1/context"}',
                 "default", None,
                 200, {"status": "ok"}, {"result": {"status": "ok"}},
-                None
+                None, None
             ),
             (
                 '{"@context": "https://w3id.org/ro/crate/1.1/context"}',
                 "default", "http://webhook",
                 500, None, {"error": "Celery error"},
-                Exception("Celery error")
+                Exception("Celery error"), None
             ),
         ],
         ids=["success_with_webhook", "success_without_webhook", "failure_celery_error"]
 )
 def test_queue_metadata(flask_app, crate_json: dict, profile: str, webhook: str,
                         status_code: int, return_value: dict, response_json: dict,
-                        delay_side_effect: Exception):
+                        delay_side_effect: Exception, profiles_path: str):
     with patch("app.services.validation_service.process_validation_task_by_metadata.delay",
                side_effect=delay_side_effect) as mock_delay:
         mock_result = MagicMock()
@@ -175,9 +175,9 @@ def test_queue_metadata(flask_app, crate_json: dict, profile: str, webhook: str,
         if delay_side_effect is None:
             mock_delay.return_value = mock_result
 
-        response, status = queue_ro_crate_metadata_validation_task(crate_json, profile, webhook)
+        response, status = queue_ro_crate_metadata_validation_task(crate_json, profile, webhook, profiles_path)
 
-        mock_delay.assert_called_once_with(crate_json, profile, webhook)
+        mock_delay.assert_called_once_with(crate_json, profile, webhook, profiles_path)
         assert status == status_code
         assert response.json == response_json