Remove the displayMode and related options.

Note that this only removes the selection as pertains to HTML display
mode choices in the user interface.  Internally, there are still display
mode decistions that are made to determine the type of problem render.

There is one case where the display mode choice is left, and that is in
the problem editor.  That is because that is a different type of choice
that is much the same as the internal decisions made elsewhere.

In short the displayMode is now only used to determine if it is
hardcopy, html, or PTX.  In some cases plainText is used to save
processing (such as in determining a new variant for a "Show Me Another"
problem).

Author: drgrice1

conf/defaults.config

@@ -1015,20 +1015,9 @@ $caliper{enabled} = 0;
 # PG subsystem options
 ################################################################################
 
-# List of enabled screen display modes. Comment out any modes you don't wish to
-# make available for use.  The first uncommented option is the default for
-# instructors rendering problems in the homework sets editor.
-$pg{displayModes} = [
-	"MathJax",    # render TeX math expressions client side using MathJax.
-
-	#"plainText",  # display raw TeX for math expressions
-];
-
-# Default display mode. Should be an uncommented item listed above.
-$pg{options}{displayMode} = "MathJax";
-
-# List of additional display modes for the PG editor only.
-$pg{additionalPGEditorDisplayModes} = [
+# List of display modes that can be selected in the PG editor.
+$pg{PGEditorDisplayModes} = [
+	"MathJax",    # render TeX math expressions using MathJax
 	"tex",        # display tex code for a rendered problem
 	"PTX",        # display static PreTeXt XML for a rendered problem
 ];

conf/localOverrides.conf.dist

@@ -273,17 +273,6 @@ $mail{feedbackRecipients}    = [
 # PG subsystem options
 ################################################################################
 
-# List of enabled screen display modes. Comment out any modes you don't wish to
-# make available for use.  The first uncommented option is the default for
-# instructors rendering problems in the homework sets editor.
-#$pg{displayModes} = [
-	#"MathJax",    # render TeX math expressions client side using MathJax.
-	#"plainText",  # display raw TeX for math expressions
-#];
-
-# Default display mode. Should be an uncommented item listed above.
-#$pg{options}{displayMode} = "plainText";
-
 ################################################################################
 #  Adding to the macro file search path. (Check with entries in defaults.config before overriding)
 ################################################################################

htdocs/js/RenderProblem/renderproblem.js

@@ -13,7 +13,6 @@
 			const ro = {
 				courseID: document.getElementsByName('hidden_course_id')[0]?.value,
 				language: document.getElementsByName('hidden_language')[0]?.value ?? 'en',
-				displayMode: document.getElementById('problem_displaymode').value ?? 'MathJax',
 				problemSeed: 1,
 				permissionLevel: 10,
 				outputformat: 'simple',

htdocs/js/Stats/stats.js

@@ -4,8 +4,6 @@
 
 	if (!webworkConfig.renderProblem) return;
 
-	const displayModeSelector = document.getElementById('problem_displaymode');
-
 	const render = () => {
 		webworkConfig.renderProblem('problem_render_area', {
 			set_id: document.getElementById('hidden_set_id')?.value,
@@ -16,7 +14,4 @@
 
 	// Render the problem on page load.
 	render();
-
-	// Re-render when a new display mode is selected.
-	displayModeSelector?.addEventListener('change', render);
 })();

lib/WeBWorK/ConfigValues.pm

@@ -689,34 +689,6 @@ sub getConfigValues ($ce) {
 		],
 		[
 			x('Problem Display/Answer Checking'),
-			{
-				# FIXME: Perhaps the pg{displayModes} and pg{options}{displayMode} options should just be deleted. The
-				# only real display mode is MathJax.  Why would anyone ever choose plainText?
-				var  => 'pg{displayModes}',
-				doc  => x('List of display modes made available to students'),
-				doc2 => x(
-					'<p>When viewing a problem, users may choose different methods of rendering formulas via an '
-						. 'options box in the left panel. Here, you can adjust what display modes are listed.</p>'
-						. '<p>The display modes are</p><ul><li>plainText: shows the raw LaTeX strings for formulas.'
-						. '</li><li>MathJax: uses javascript to render mathematics.</li></ul><p>You must use at least '
-						. 'one display mode. If you select only one, then the options box will not give a choice of '
-						. 'modes (since there will only be one active).</p>'
-				),
-				min    => 1,
-				values => [ 'MathJax', 'plainText' ],
-				type   => 'checkboxlist'
-			},
-			{
-				var  => 'pg{options}{displayMode}',
-				doc  => x('The default display mode'),
-				doc2 => x(
-					'Enter one of the allowed display mode types above. See the help for the '
-						. '"List of display modes made available to students" options for descriptions.'
-				),
-				min    => 1,
-				values => [qw(MathJax plainText)],
-				type   => 'popuplist'
-			},
 			{
 				var  => 'pg{specialPGEnvironmentVars}{entryAssist}',
 				doc  => x('Assist with the student answer entry process.'),

lib/WeBWorK/ContentGenerator.pm

@@ -512,10 +512,7 @@ sub links ($c) {
 	}
 
 	# System link parameters that are common to all links (except the Courses link).
-	my %systemlink_params = (
-		$c->param('displayMode')    ? (displayMode    => $c->param('displayMode'))    : (),
-		$c->param('showOldAnswers') ? (showOldAnswers => $c->param('showOldAnswers')) : ()
-	);
+	my %systemlink_params = ($c->param('showOldAnswers') ? (showOldAnswers => $c->param('showOldAnswers')) : ());
 
 	my $current_url = $c->url_for;
 

lib/WeBWorK/ContentGenerator/Feedback.pm

@@ -21,7 +21,6 @@ use WeBWorK::Utils qw(createEmailSenderTransportSMTP fetchEmailRecipients format
 # route
 # set (if from ProblemSet or Problem)
 # problem (if from Problem)
-# displayMode (if from Problem)
 # showOldAnswers (if from Problem)
 # showCorrectAnswers (if from Problem)
 # showHints (if from Problem)

lib/WeBWorK/ContentGenerator/GatewayQuiz.pm

@@ -774,8 +774,6 @@ async sub pre_header_initialize ($c) {
 	# false if the "pageChangeHack" input is set (a page change link was used).
 	$c->param('previewAnswers', 0) if $c->param('pageChangeHack');
 
-	$c->{displayMode} = $user->displayMode || $ce->{pg}{options}{displayMode};
-
 	# Set options from request parameters.
 	$c->{redisplay}      = $c->param('redisplay');
 	$c->{submitAnswers}  = $c->param('submitAnswers') || 0;
@@ -1484,7 +1482,6 @@ async sub getProblemHTML ($c, $effectiveUser, $set, $formFields, $mergedProblem)
 		$set->psvn,
 		$formFields,
 		{
-			displayMode        => $c->{displayMode},
 			showHints          => $c->{will}{showHints},
 			showSolutions      => $c->{will}{showSolutions},
 			processAnswers     => 1,

lib/WeBWorK/ContentGenerator/Instructor/PGProblemEditor.pm

@@ -146,7 +146,7 @@ sub pre_header_initialize ($c) {
 	# Determine displayMode and problemSeed that are needed for viewing the problem.
 	# They are also two of the parameters which can be set by the editor.
 	# Note that the problem seed may be overridden by the value obtained from the problem record later.
-	$c->{displayMode} = $c->param('displayMode') // $ce->{pg}{options}{displayMode};
+	$c->{displayMode} = $c->param('displayMode') // 'MathJax';
 	$c->{problemSeed} = (($c->param('problemSeed') // '') =~ s/^\s*|\s*$//gr) || DEFAULT_SEED();
 
 	# Insure that file_type is defined
@@ -745,7 +745,7 @@ sub fixProblemContents {
 
 sub view_handler ($c) {
 	my $problemSeed = $c->param('action.view.seed')        // DEFAULT_SEED();
-	my $displayMode = $c->param('action.view.displayMode') // $c->ce->{pg}{options}{displayMode};
+	my $displayMode = $c->param('action.view.displayMode') // 'MathJax';
 
 	# Grab the problemContents from the form in order to save it to the tmp file.
 	$c->{r_problemContents} = \(fixProblemContents($c->param('problemContents')));

lib/WeBWorK/ContentGenerator/Instructor/ProblemGrader.pm

@@ -171,7 +171,7 @@ async sub initialize ($c) {
 	# These should always be defined except for some odd edge cases.
 	return unless $set && $problem;
 
-	# Get the current user for the displayMode.
+	# Get the current user.
 	my $user = $db->getUser($userID);
 
 	# Render the problem text.
@@ -182,7 +182,6 @@ async sub initialize ($c) {
 		$set->psvn,
 		{},
 		{
-			displayMode              => $user->displayMode || $c->ce->{pg}{options}{displayMode},
 			showHints                => 0,
 			showSolutions            => 0,
 			processAnswers           => 1,