Simplify form validation mixin API

Remove validateNewState and validateEditState convenience wrappers.
Components now call getValidationState directly with the form state key.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: Tim020

client/src/mixins/formValidationMixin.js

@@ -50,28 +50,6 @@ export default {
       return $dirty ? !$error : null;
     },
 
-    /**
-     * Validate state for a field in newFormState.
-     * Convenience method that wraps getValidationState.
-     *
-     * @param {string} fieldName - The field name to validate
-     * @returns {boolean|null} - Bootstrap validation state
-     */
-    validateNewState(fieldName) {
-      return this.getValidationState('newFormState', fieldName);
-    },
-
-    /**
-     * Validate state for a field in editFormState.
-     * Convenience method that wraps getValidationState.
-     *
-     * @param {string} fieldName - The field name to validate
-     * @returns {boolean|null} - Bootstrap validation state
-     */
-    validateEditState(fieldName) {
-      return this.getValidationState('editFormState', fieldName);
-    },
-
     /**
      * Reset a form to its initial state and reset validation.
      *

client/src/views/show/config/ConfigCast.vue

@@ -71,7 +71,7 @@
             id="new-first-name-input"
             v-model="$v.newFormState.firstName.$model"
             name="new-first-name-input"
-            :state="validateNewState('firstName')"
+            :state="getValidationState('newFormState', 'firstName')"
             aria-describedby="new-first-name-feedback"
           />
           <b-form-invalid-feedback id="new-first-name-feedback">
@@ -87,7 +87,7 @@
             id="new-last-name-input"
             v-model="$v.newFormState.lastName.$model"
             name="new-last-name-input"
-            :state="validateNewState('lastName')"
+            :state="getValidationState('newFormState', 'lastName')"
             aria-describedby="new-last-name-feedback"
           />
           <b-form-invalid-feedback id="new-last-name-feedback">
@@ -115,7 +115,7 @@
             id="edit-first-name-input"
             v-model="$v.editFormState.firstName.$model"
             name="edit-first-name-input"
-            :state="validateEditState('firstName')"
+            :state="getValidationState('editFormState', 'firstName')"
             aria-describedby="edit-first-name-feedback"
           />
           <b-form-invalid-feedback id="edit-first-name-feedback">
@@ -131,7 +131,7 @@
             id="edit-last-name-input"
             v-model="$v.editFormState.lastName.$model"
             name="edit-last-name-input"
-            :state="validateEditState('lastName')"
+            :state="getValidationState('editFormState', 'lastName')"
             aria-describedby="edit-last-name-feedback"
           />
           <b-form-invalid-feedback id="edit-last-name-feedback">

client/src/views/show/config/ConfigCharacters.vue

@@ -78,7 +78,7 @@
             id="new-name-input"
             v-model="$v.newFormState.name.$model"
             name="new-name-input"
-            :state="validateNewState('name')"
+            :state="getValidationState('newFormState', 'name')"
             aria-describedby="new-name-feedback"
           />
           <b-form-invalid-feedback id="new-name-feedback">
@@ -94,7 +94,7 @@
             id="new-description-input"
             v-model="$v.newFormState.description.$model"
             name="new-description-input"
-            :state="validateNewState('description')"
+            :state="getValidationState('newFormState', 'description')"
           />
         </b-form-group>
         <b-form-group
@@ -106,7 +106,7 @@
             id="new-played-by-input"
             v-model="$v.newFormState.played_by.$model"
             :options="castOptions"
-            :state="validateNewState('played_by')"
+            :state="getValidationState('newFormState', 'played_by')"
           />
         </b-form-group>
       </b-form>
@@ -126,7 +126,7 @@
             id="edit-name-input"
             v-model="$v.editFormState.name.$model"
             name="edit-name-input"
-            :state="validateEditState('name')"
+            :state="getValidationState('editFormState', 'name')"
             aria-describedby="edit-name-feedback"
           />
           <b-form-invalid-feedback id="edit-name-feedback">
@@ -142,7 +142,7 @@
             id="edit-description-input"
             v-model="$v.editFormState.description.$model"
             name="edit-description-input"
-            :state="validateEditState('description')"
+            :state="getValidationState('editFormState', 'description')"
           />
         </b-form-group>
         <b-form-group
@@ -154,7 +154,7 @@
             id="edit-played-by-input"
             v-model="$v.editFormState.played_by.$model"
             :options="castOptions"
-            :state="validateEditState('played_by')"
+            :state="getValidationState('editFormState', 'played_by')"
           />
         </b-form-group>
       </b-form>

client/src/vue_components/show/config/acts_and_scenes/ConfigActs.vue

@@ -72,7 +72,7 @@
             id="new-name-input"
             v-model="$v.newFormState.name.$model"
             name="new-name-input"
-            :state="validateNewState('name')"
+            :state="getValidationState('newFormState', 'name')"
             aria-describedby="new-name-feedback"
           />
           <b-form-invalid-feedback id="new-name-feedback">
@@ -119,7 +119,7 @@
             id="edit-name-input"
             v-model="$v.editFormState.name.$model"
             name="edit-name-input"
-            :state="validateEditState('name')"
+            :state="getValidationState('editFormState', 'name')"
             aria-describedby="edit-name-feedback"
           />
           <b-form-invalid-feedback id="edit-name-feedback">
@@ -146,7 +146,7 @@
             id="edit-previous-act-input"
             v-model="$v.editFormState.previous_act_id.$model"
             :options="editFormActOptions"
-            :state="validateEditState('previous_act_id')"
+            :state="getValidationState('editFormState', 'previous_act_id')"
             aria-describedby="edit-previous-act-feedback"
           />
           <b-form-invalid-feedback id="edit-previous-act-feedback">

client/src/vue_components/show/config/acts_and_scenes/ConfigScenes.vue

@@ -96,7 +96,7 @@
             id="new-name-input"
             v-model="$v.newFormState.name.$model"
             name="new-name-input"
-            :state="validateNewState('name')"
+            :state="getValidationState('newFormState', 'name')"
             aria-describedby="new-name-feedback"
           />
           <b-form-invalid-feedback id="new-name-feedback">
@@ -108,7 +108,7 @@
             id="new-act-input"
             v-model="$v.newFormState.act_id.$model"
             :options="actOptions"
-            :state="validateNewState('act_id')"
+            :state="getValidationState('newFormState', 'act_id')"
             aria-describedby="new-act-feedback"
           />
           <b-form-invalid-feedback id="new-act-feedback">
@@ -144,7 +144,7 @@
             id="edit-name-input"
             v-model="$v.editFormState.name.$model"
             name="edit-name-input"
-            :state="validateEditState('name')"
+            :state="getValidationState('editFormState', 'name')"
             aria-describedby="edit-name-feedback"
           />
           <b-form-invalid-feedback id="edit-name-feedback">
@@ -156,7 +156,7 @@
             id="edit-act-input"
             v-model="$v.editFormState.act_id.$model"
             :options="actOptions"
-            :state="validateEditState('act_id')"
+            :state="getValidationState('editFormState', 'act_id')"
             aria-describedby="edit-act-feedback"
             @change="editActChanged"
           />
@@ -173,7 +173,7 @@
             id="edit-previous-scene-input"
             v-model="$v.editFormState.previous_scene_id.$model"
             :options="editFormPrevScenes"
-            :state="validateEditState('previous_scene_id')"
+            :state="getValidationState('editFormState', 'previous_scene_id')"
             aria-describedby="edit-previous-scene-feedback"
           />
           <b-form-invalid-feedback id="edit-previous-scene-feedback">

client/src/vue_components/show/config/characters/CharacterGroups.vue

@@ -67,7 +67,7 @@
             id="new-name-input"
             v-model="$v.newFormState.name.$model"
             name="new-name-input"
-            :state="validateNewState('name')"
+            :state="getValidationState('newFormState', 'name')"
             aria-describedby="new-name-feedback"
           />
           <b-form-invalid-feedback id="new-name-feedback">
@@ -83,7 +83,7 @@
             id="new-description-input"
             v-model="$v.newFormState.description.$model"
             name="new-description-input"
-            :state="validateNewState('description')"
+            :state="getValidationState('newFormState', 'description')"
           />
         </b-form-group>
         <b-form-group
@@ -99,7 +99,7 @@
             :options="CHARACTER_LIST"
             track-by="id"
             label="name"
-            :state="validateNewState('characters')"
+            :state="getValidationState('newFormState', 'characters')"
             @input="newSelectChanged"
           />
         </b-form-group>
@@ -120,7 +120,7 @@
             id="edit-name-input"
             v-model="$v.editFormState.name.$model"
             name="edit-name-input"
-            :state="validateEditState('name')"
+            :state="getValidationState('editFormState', 'name')"
             aria-describedby="edit-name-feedback"
           />
           <b-form-invalid-feedback id="edit-name-feedback">
@@ -136,7 +136,7 @@
             id="edit-description-input"
             v-model="$v.editFormState.description.$model"
             name="edit-description-input"
-            :state="validateEditState('description')"
+            :state="getValidationState('editFormState', 'description')"
           />
         </b-form-group>
         <b-form-group
@@ -152,7 +152,7 @@
             :options="CHARACTER_LIST"
             track-by="id"
             label="name"
-            :state="validateEditState('characters')"
+            :state="getValidationState('editFormState', 'characters')"
             @input="editSelectChanged"
           />
         </b-form-group>

client/src/vue_components/show/config/stage/CrewList.vue

@@ -47,7 +47,7 @@
             id="new-first-name-input"
             v-model="$v.newFormState.firstName.$model"
             name="new-first-name-input"
-            :state="validateNewState('firstName')"
+            :state="getValidationState('newFormState', 'firstName')"
             aria-describedby="new-first-name-feedback"
           />
           <b-form-invalid-feedback id="new-first-name-feedback">
@@ -63,7 +63,7 @@
             id="new-last-name-input"
             v-model="$v.newFormState.lastName.$model"
             name="new-last-name-input"
-            :state="validateNewState('lastName')"
+            :state="getValidationState('newFormState', 'lastName')"
             aria-describedby="new-last-name-feedback"
           />
           <b-form-invalid-feedback id="new-last-name-feedback">
@@ -90,7 +90,7 @@
             id="edit-first-name-input"
             v-model="$v.editFormState.firstName.$model"
             name="edit-first-name-input"
-            :state="validateEditState('firstName')"
+            :state="getValidationState('editFormState', 'firstName')"
             aria-describedby="edit-first-name-feedback"
           />
           <b-form-invalid-feedback id="edit-first-name-feedback">
@@ -106,7 +106,7 @@
             id="edit-last-name-input"
             v-model="$v.editFormState.lastName.$model"
             name="edit-last-name-input"
-            :state="validateEditState('lastName')"
+            :state="getValidationState('editFormState', 'lastName')"
             aria-describedby="edit-last-name-feedback"
           />
           <b-form-invalid-feedback id="edit-last-name-feedback">

client/src/vue_components/user/settings/CueColourPreferences.vue

@@ -62,7 +62,7 @@
                 v-model="$v.newFormState.colour.$model"
                 name="new-colour-input"
                 type="color"
-                :state="validateNewState('colour')"
+                :state="getValidationState('newFormState', 'colour')"
                 aria-describedby="new-colour-feedback"
               />
               <b-form-invalid-feedback id="new-colour-feedback">
@@ -106,7 +106,7 @@
                 v-model="$v.editFormState.colour.$model"
                 name="edit-colour-input"
                 type="color"
-                :state="validateEditState('colour')"
+                :state="getValidationState('editFormState', 'colour')"
                 aria-describedby="edit-colour-feedback"
               />
               <b-form-invalid-feedback id="edit-colour-feedback">