Skip to content

Commit 113ca9f

Browse files
author
Leonid Makarov
committed
Fixed docker push for PHP 7.4 image
1 parent 5399d83 commit 113ca9f

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

7.4/Makefile

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,8 @@
33

44
VERSION ?= 7.4
55

6-
# tag naming schema: <image-repo>:[<software-version>-]<image-stability-tag>[-tag-appendix][-<flavor>]
7-
# uncomment lines bellow if you want include this in tag name
8-
# SOFTWARE_VERSION ?= $(VERSION)
9-
# FLAVOR =? custom
10-
11-
TAG_APPENDIX ?= php$(VERSION)
12-
BUILD_TAG = build-$(TAG_APPENDIX)
6+
SOFTWARE_VERSION ?= php$(VERSION)
7+
BUILD_TAG = build-$(SOFTWARE_VERSION)
138
REPO = docksal/cli
149
NAME = docksal-cli-$(VERSION)
1510
CWD = $(shell pwd)
@@ -22,7 +17,7 @@ VOLUMES += -v /home/docker
2217
.PHONY: build test push shell run start stop logs clean release
2318

2419
build:
25-
docker build --cache-from=$(REPO):edge$(TAG_APPENDIX) -t $(REPO):$(BUILD_TAG) .
20+
docker build --cache-from=$(REPO):edge-$(SOFTWARE_VERSION) -t $(REPO):$(BUILD_TAG) .
2621

2722
test:
2823
IMAGE=$(REPO):$(BUILD_TAG) NAME=$(NAME) VERSION=$(VERSION) ../tests/test.bats

0 commit comments

Comments
 (0)