DDRMenu, INodeManipulator error

[leedavi]

Description of bug

The problem is linked to the "TabId" property of the NodeMenu class. The TabId MUST be a valid page in DNN. If not it drops the page from the menu. You might think this sounds reasonable, but there is little point having a DDRMenu NodeManipulor if you can only use valid DNN pages.

If you try values of "-1, "0", "1". The extra nodes are also dropped. I assume that this is because the page in the DDRMenu takes on the settings of the real page and hence is hidden and does not appear on the menu.

If you use a Page that is displayed on the menu, then the extra MenuNodes will appear. But this is little good.

Steps to reproduce

Use OpenStore and inject the categoies into the DDRMenu https://www.openstore-ecommerce.com/en-gb/

Current result

The categories will not appear.

Expected result

Categories appear in DDRMenu

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

• 9.3.0
• 9.2.2
• 9.2.1 ??

[valadas]

If you reference Dnn 9.2.2 dll and try to compile, do you get errors or it compiles fine? I know the NodeManipulator is still there but I remember having some troubles with MenuNode or something else closely related to the nodes in another module (the gallery Core module) I tried to migrate to Dnn 9.2 and ran out of time to do it,

[leedavi]

OK, thx for the advice Daniel. But I have tried to compile against v9.3.0 and it compiles OK.

I can get a fix in OpenStore, because of the way we inject the menu, but I still think it needs fixing.

[valadas]

I am closing this issue in the spirit of cleaning the backlog because:

1. This would be risky to implement if a lot of other stuff expects the TabId to always be valid, this could be a huge breaking change and a risk
2. This could have security implications regarding tab permissions
3. There is a way around the situation

I think we could reopen this issue only if we have an action plan and proof of concept and tests that ensure that points 1 and 2 are taken into account.

[leedavi]

Hi Daniel, I disagree with the reasons.

1. What uses non existing tabs in the menu? I doubt anything does, this was working in DNN8. It's a bug introduced in DNN9. Not many people compile their projects against DNN9.
2. Nothing on tab permissions is changed, I don't understand why you think there is a tab permissions issue? We are simply adding links to a menu, nothing to do with security, unless you build it into the DDRMenu interface.
3. I found a way around in OpenStore, but not everyone would find a workaround. Most modules that use this interface will not work in DNN9. I suppose the only true workaround is to use another menu.

If you said, "too much time to fix", I could understand..

On the scale of what needs doing in DNN9, this is small potatoes. I reported it because I do consider it a bug/breaking change and I think it does reflect a negative view for DNN9. But, I'll not push anyone on this.

When DNN9 can compile, "out of the box". I'll see if I can push the fix at you guys.

Have a good day.

[leedavi]

You should put a "Won't fix" label on this, so people can understand without having to read it all.

[valadas]

Oh, I am happy to reopen for further discussions and even more if you are willing to offer something on it. I am just trying to clean stale issues and assign everything actionable to some milestone. I am setting this to the Dnn 10 milestone but it is not set in stone, let's call it a goal... :)

[leedavi]

OK, Great. Thx. :-)

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[valadas]

I am re-closing this issue since it was reopen for further discussion but nothing progresses since July. If there are any news, please comment or reopen.