Skip to content

Commit e91dea6

Browse files
committed
v1.7.3: disabled RealMLP lightning log files, removed pynvml dependency
1 parent 33cbf23 commit e91dea6

6 files changed

Lines changed: 7 additions & 19 deletions

File tree

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,10 @@ and https://docs.ray.io/en/latest/cluster/vms/user-guides/community/slurm.html
200200

201201
## Releases (see git tags)
202202

203+
- v1.7.3:
204+
- disabled RealMLP lightning log file creation that was accidentally introduced
205+
in predict() in >=v1.7.0.
206+
- removed pynvml dependency.
203207
- v1.7.2:
204208
- Added scikit-learn 1.8 compatibility.
205209
- Removed debug print in RealMLP.

docs/requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ pandas>=2.0
1515
patool>=1.0
1616
probmetrics>=0.0.1
1717
psutil>=5.0
18-
pynvml>=11.0
1918
pytest-cov>=4.0
2019
pytest>=7.0
2120
pytorch_lightning>=2.0

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ hpo = [
9090
bench = [
9191
"fire", # argparse utilities
9292
"ray>=2.8", # parallelization
93-
"pynvml>=11.0", # NVIDIA GPU utilization
9493
"openml>=0.14", # OpenML data download
9594
# ----- UCI import ------
9695
"requests>=2.0",

pytabkit/__about__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5-
__version__ = "1.7.2"
5+
__version__ = "1.7.3"

pytabkit/bench/scheduling/execution.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,6 @@ def measure_node_resources(node_id: int) -> Tuple[NodeResources, NodeResources]:
6262
# alloc dummy tensors to know how much memory PyTorch uses for its runtime
6363
dummy_tensors = [torch.ones(1).to(f'cuda:{i}') for i in range(n_gpus)]
6464
gpu_rams_gb, gpu_rams_fixed_gb = get_gpu_rams_gb()
65-
# import pynvml
66-
# pynvml.nvmlInit()
67-
#
68-
# gpu_rams_gb = []
69-
# gpu_rams_fixed_gb = []
70-
#
71-
# for i in range(n_gpus):
72-
# # adapted torch.cuda.list_gpu_processes(gpu)
73-
# h = pynvml.nvmlDeviceGetHandleByIndex(i)
74-
# info = pynvml.nvmlDeviceGetMemoryInfo(h)
75-
# total = info.total
76-
# # print(f'free : {info.free}')
77-
# used = info.used
78-
# gpu_rams_gb.append(total / (1024. ** 3))
79-
# gpu_rams_fixed_gb.append(used / (1024. ** 3))
8065
else:
8166
gpu_rams_gb = []
8267
gpu_rams_fixed_gb = []

pytabkit/models/alg_interfaces/nn_interfaces.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,8 @@ def predict(self, ds: DictDataset) -> torch.Tensor:
166166

167167
# create new trainer so we don't have to pickle the full trainer that references the dataset somehow
168168
# update devices since the model device may have been moved since
169-
trainer = pl.Trainer(**(self.min_trainer_kwargs | dict(accelerator=pl_accelerator, devices=pl_devices)))
169+
trainer = pl.Trainer(**(self.min_trainer_kwargs | dict(accelerator=pl_accelerator, devices=pl_devices,
170+
logger=pl.loggers.logger.DummyLogger())))
170171
y_pred = trainer.predict(model=self.model, dataloaders=self.model.get_predict_dataloader(ds_x))
171172
y_pred = cat_if_necessary(y_pred, dim=-2).to('cpu') # concat along batch dimension
172173
y_pred = postprocess_multiquantile(y_pred, **self.config) # postprocessing in case of multiquantile loss

0 commit comments

Comments
 (0)