test: Refactor IC-OS image config in system_tests.bzl for more clarity (#8436)

- Instead of the `uses_*` pattern, pass `hostos` and `setupos` args to
`system_test` similarly to `guestos`.
- Factor out repeating parts of the config in `system_tests.bzl` into
functions
- Improve handling of mainnet dev images.
- Behavior change: `recovery-dev` now builds the initial update image
corresponding to the base image (both from
`//ic-os/guestos/envs/recovery-dev`), whereas previously the two weren't
consistent. The test still passes and I got green light from
@andrewbattat who originally wrote the tests.

---------

Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>

Author: frankdavid

rs/tests/nested/BUILD.bazel

@@ -48,9 +48,9 @@ system_test_nns(
     name = "registration",
     env = MAINNET_ENV,
     flaky = True,  # flakiness rate of over 2% over the month from 2025-02-11 till 2025-03-11.
+    setupos = True,
     tags = ["long_test"],  # since it takes longer than 5 minutes.
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
     deps = [
         # Keep sorted.
@@ -81,10 +81,10 @@ system_test_nns(
     env = MAINNET_ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_driver_target = ":guestos_upgrade_test_bin",
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
 )
 
@@ -94,10 +94,10 @@ system_test_nns(
     flaky = True,
     guestos = "mainnet_latest_dev",  # necessary for configuring NNS public key
     guestos_update = True,
+    setupos = "mainnet_latest_dev",
     tags = ["long_test"],
     test_driver_target = ":guestos_upgrade_test_bin",
     test_timeout = "eternal",
-    uses_setupos_mainnet_latest_img = True,
     runtime_deps = IC_GATEWAY_RUNTIME_DEPS | {
         "NODE_OPERATOR_PRIV_KEY_PATH": "//ic-os/setupos:config/node_operator_private_key.pem",
     },
@@ -122,11 +122,11 @@ system_test_nns(
     name = "hostos_upgrade_smoke_test",
     env = MAINNET_ENV,
     flaky = True,
+    hostos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_driver_target = ":hostos_upgrade_test_bin",
     test_timeout = "eternal",
-    uses_hostos_test_update = True,
-    uses_setupos_img = True,
     runtime_deps = IC_GATEWAY_RUNTIME_DEPS,
 )
 
@@ -135,11 +135,11 @@ system_test_nns(
     name = "hostos_upgrade_from_latest_release_to_current",
     flaky = True,  # flakiness rate of 5% over the month from 2025-02-11 till 2025-03-11.
     guestos = "mainnet_latest_dev",  # necessary for configuring NNS public key
+    hostos_update = True,
+    setupos = "mainnet_latest_dev",
     tags = ["long_test"],
     test_driver_target = ":hostos_upgrade_test_bin",
     test_timeout = "eternal",
-    uses_hostos_update = True,
-    uses_setupos_mainnet_latest_img = True,
     runtime_deps = IC_GATEWAY_RUNTIME_DEPS | {
         "NODE_OPERATOR_PRIV_KEY_PATH": "//ic-os/setupos:config/node_operator_private_key.pem",
     },

rs/tests/nested/nns_recovery/BUILD.bazel

@@ -45,9 +45,9 @@ system_test_nns(
     env = ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = RUNTIME_DEPS,
     deps = [
         # Keep sorted.
@@ -66,12 +66,12 @@ system_test_nns(
     env = ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = [
         "manual",
         "system_test_large",
     ],
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = RUNTIME_DEPS,
     deps = [
         # Keep sorted.
@@ -86,9 +86,9 @@ system_test_nns(
     env = ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = RUNTIME_DEPS,
     deps = [
         # Keep sorted.
@@ -106,9 +106,9 @@ system_test_nns(
     env = ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = RUNTIME_DEPS,
     deps = [
         # Keep sorted.
@@ -126,9 +126,9 @@ system_test_nns(
     env = ENV,
     flaky = True,
     guestos_update = "test",
+    setupos = True,
     tags = ["long_test"],
     test_timeout = "eternal",
-    uses_setupos_img = True,
     runtime_deps = RUNTIME_DEPS,
     deps = [
         # Keep sorted.

rs/tests/node/BUILD.bazel

@@ -98,11 +98,11 @@ system_test(
 system_test(
     name = "launch_single_host",
     guestos = False,
+    setupos = True,
     tags = [
         "dynamic_testnet",
         "manual",
     ],
-    uses_setupos_img = True,
     deps = [
         # Keep sorted.
         "//rs/tests/driver:ic-system-test-driver",