fix: PocketIcBuilder::with_nns_state and PocketIcBuilder::with_subnet_state on Windows (#8628)

This PR makes the PocketIC library perform the conversion of the state
directory path from its Windows-native form to the WSL-native form. This
way, users of the PocketIC library (e.g., tests) do not have to perform
the conversion repeatedly at all call sites.

Author: mraszyk

packages/pocket-ic/src/lib.rs

@@ -347,7 +347,11 @@ impl PocketIcBuilder {
     ///  `-- tmp
     pub fn with_subnet_state(mut self, subnet_kind: SubnetKind, path_to_state: PathBuf) -> Self {
         let mut config = self.config.unwrap_or_default();
-        let subnet_spec = SubnetSpec::default().with_state_dir(path_to_state);
+        #[cfg(not(windows))]
+        let state_dir = path_to_state;
+        #[cfg(windows)]
+        let state_dir = wsl_path(&path_to_state, "subnet state").into();
+        let subnet_spec = SubnetSpec::default().with_state_dir(state_dir);
         match subnet_kind {
             SubnetKind::NNS => config.nns = Some(subnet_spec),
             SubnetKind::SNS => config.sns = Some(subnet_spec),

packages/pocket-ic/tests/icp_features.rs

@@ -34,8 +34,6 @@ use std::collections::BTreeMap;
 use std::io::Read;
 use std::time::Duration;
 use tempfile::TempDir;
-#[cfg(windows)]
-use wslpath::windows_to_wsl;
 
 mod common;
 
@@ -1020,12 +1018,7 @@ fn read_registry() {
 )]
 fn with_all_icp_features_and_nns_state() {
     let state_dir = TempDir::new().unwrap();
-    #[cfg(not(windows))]
     let state_dir_path_buf = state_dir.path().to_path_buf();
-    #[cfg(windows)]
-    let state_dir_path_buf = windows_to_wsl(state_dir.path().as_os_str().to_str().unwrap())
-        .unwrap()
-        .into();
 
     let _pic = PocketIcBuilder::new()
         .with_icp_features(all_icp_features())
@@ -1036,12 +1029,7 @@ fn with_all_icp_features_and_nns_state() {
 #[tokio::test]
 async fn with_all_icp_features_and_nns_subnet_state() {
     let state_dir = TempDir::new().unwrap();
-    #[cfg(not(windows))]
     let state_dir_path_buf = state_dir.path().to_path_buf();
-    #[cfg(windows)]
-    let state_dir_path_buf = windows_to_wsl(state_dir.path().as_os_str().to_str().unwrap())
-        .unwrap()
-        .into();
 
     let (_, url) = start_server(StartServerParams::default()).await;
     let client = reqwest::Client::new();

packages/pocket-ic/tests/tests.rs

@@ -30,8 +30,6 @@ use std::{
     time::{Duration, SystemTime},
 };
 use tempfile::{NamedTempFile, TempDir};
-#[cfg(windows)]
-use wslpath::windows_to_wsl;
 
 mod common;
 
@@ -2783,12 +2781,7 @@ fn test_specified_id_on_resumed_state() {
 #[should_panic(expected = "is not a (subnet state) directory")]
 fn with_subnet_state_file() {
     let state_file = NamedTempFile::new().unwrap();
-    #[cfg(not(windows))]
     let state_file_path_buf = state_file.path().to_path_buf();
-    #[cfg(windows)]
-    let state_file_path_buf = windows_to_wsl(state_file.path().as_os_str().to_str().unwrap())
-        .unwrap()
-        .into();
 
     let _pic = PocketIcBuilder::new()
         .with_subnet_state(SubnetKind::Application, state_file_path_buf)
@@ -2799,12 +2792,7 @@ fn with_subnet_state_file() {
 #[should_panic(expected = "Provided an empty state directory at path")]
 fn with_empty_subnet_state() {
     let state_dir = TempDir::new().unwrap();
-    #[cfg(not(windows))]
     let state_dir_path_buf = state_dir.path().to_path_buf();
-    #[cfg(windows)]
-    let state_dir_path_buf = windows_to_wsl(state_dir.path().as_os_str().to_str().unwrap())
-        .unwrap()
-        .into();
 
     let _pic = PocketIcBuilder::new()
         .with_subnet_state(SubnetKind::Application, state_dir_path_buf)