Skip to content

Commit 2e2df34

Browse files
authored
fix: New ICP Ninja examples issues (#1265)
* fix duplicate asset in QR code example occurring when deploying with Calm * remove Svelte Starter from Ninja * use variable for key type in schnorr motoko
1 parent 926e1d3 commit 2e2df34

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.github/workflows/ninja_pr_checks.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ jobs:
7777
["Photo Gallery (Rust)"]="rust/photo_gallery"
7878
["Inter-canister calls (Rust)"]="rust/inter-canister-calls"
7979
["X.509 (Rust)"]="rust/x509"
80-
["Svelte Starter (Svelte)"]="svelte/svelte-starter"
8180
)
8281
8382
# Check if we should run all examples (workflow file changed) or just changed ones

motoko/threshold-schnorr/src/schnorr_example_motoko/main.mo

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ persistent actor {
4646
let { public_key } = await ic.schnorr_public_key({
4747
canister_id = null;
4848
derivation_path = [Principal.toBlob(caller)];
49-
key_id = { algorithm; name = "dfx_test_key" };
49+
key_id = { algorithm; name = key_id };
5050
});
5151
#Ok({ public_key_hex = Hex.encode(Blob.toArray(public_key)) });
5252
} catch (err) {
@@ -69,7 +69,7 @@ persistent actor {
6969
let signArgs = {
7070
message = Text.encodeUtf8(message_arg);
7171
derivation_path = [Principal.toBlob(caller)];
72-
key_id = { algorithm; name = "dfx_test_key" };
72+
key_id = { algorithm; name = key_id };
7373
aux;
7474
};
7575
let { signature } = await ic.sign_with_schnorr(signArgs);

rust/qrcode/dfx.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"frontend": {
1616
"entrypoint": "src/qrcode_frontend/src/index.html"
1717
},
18-
"source": ["src/qrcode_frontend/assets", "dist/qrcode_frontend/"],
18+
"source": ["dist/qrcode_frontend/"],
1919
"type": "assets"
2020
}
2121
},

rust/qrcode/webpack.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ module.exports = {
6969
new CopyPlugin({
7070
patterns: [
7171
{
72-
from: `src/${frontendDirectory}/src/.ic-assets.json*`,
73-
to: ".ic-assets.json5",
72+
from: `src/${frontendDirectory}/assets`,
73+
to: "./",
7474
noErrorOnMissing: true,
7575
},
7676
],

0 commit comments

Comments
 (0)