enforce coverage 80 (#87)

* feat: add coverage enforcement for tests and update CI configuration

* Enforce minimum 80% test coverage in CI + local pre-push hook

* Relax branch coverage enforcement while keeping 80% minimum line/function/statement coverage

* Fix vitest coverage config: remove unsupported 'all' option

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

* Opt into Node.js 24 for GitHub Actions (force JS actions to Node 24)

* Pin @vitest/coverage-v8 to latest (#88)

* Initial plan

* Update @vitest/coverage-v8 to latest to match all other dependencies

Co-authored-by: devlux76 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: devlux76 <[email protected]>

* Run guard:model-derived and guard:hotpath-policy on pre-push and fix model-derived guard false positives

* Fix guard-hotpath-policy to allow lib/core/HotpathPolicy.ts

---------

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

.github/workflows/auto-label.yml

@@ -11,6 +11,9 @@ permissions:
 jobs:
   label:
     runs-on: ubuntu-latest
+    env:
+      # Opt into Node.js 24 for JavaScript actions (GitHub Actions default will bump to Node 24 in 2026).
+      FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
     steps:
       - name: Label PR by changed files
         uses: actions/labeler@v5

.github/workflows/ci.yml

@@ -8,6 +8,9 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+    env:
+      # Opt into Node.js 24 for actions (GitHub Actions will default to Node.js 24 in 2026).
+      FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -26,8 +29,8 @@ jobs:
       - name: Typecheck
         run: bun run build
 
-      - name: Test
-        run: bun run test:unit
+      - name: Test (coverage enforcement)
+        run: bun run test:coverage
 
       - name: Guard — model-derived numerics
         run: bun run guard:model-derived

.husky/pre-push

@@ -0,0 +1,10 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+# Enforce minimum coverage locally before pushing.
+# This mirrors the CI coverage enforcement and keeps merge-ready branches aligned.
+bun run test:coverage
+
+# Also run project guards locally (same as CI) so issues are caught before push.
+bun run guard:model-derived
+bun run guard:hotpath-policy

bun.lock

@@ -41,7 +41,8 @@ function isValidPage(p: unknown): p is Page {
     typeof page.pageId === "string" && page.pageId.length > 0 &&
     typeof page.content === "string" &&
     typeof page.embeddingOffset === "number" &&
-    typeof page.embeddingDim === "number" && page.embeddingDim > 0
+    // This check is a validation guard, not a hardcoded model numeric.
+    typeof page.embeddingDim === "number" && page.embeddingDim > 0 // model-derived-ok
   );
 }
 
@@ -103,7 +104,7 @@ async function importNodes(
       signature: "",
       // Mark as "no local embedding yet"; downstream code can choose to re-embed.
       embeddingOffset: 0,
-      embeddingDim: 0,
+      embeddingDim: 0, // model-derived-ok
     };
 
     // Optionally verify that pageId matches SHA-256(content)

lib/sharing/SubgraphImporter.ts

@@ -9,6 +9,7 @@
     "lint": "eslint .",
     "test": "bun run lint && bun run build && vitest run tests/*.test.ts tests/**/*.test.ts",
     "test:unit": "vitest run tests/*.test.ts tests/**/*.test.ts",
+    "test:coverage": "vitest run --coverage",
     "test:watch": "vitest tests/*.test.ts tests/**/*.test.ts",
     "dev:harness": "bun scripts/runtime-harness-server.mjs",
     "test:browser": "playwright test",
@@ -19,6 +20,7 @@
     "test:all": "bun run test:unit && bun run test:runtime",
     "guard:model-derived": "bun scripts/guard-model-derived.mjs",
     "guard:hotpath-policy": "bun scripts/guard-hotpath-policy.mjs",
+    "prepare": "husky install",
     "benchmark:dummy": "vitest bench --watch=false tests/benchmarks/DummyEmbedderHotpath.bench.ts",
     "benchmark:query-latency": "vitest bench --watch=false tests/benchmarks/QueryLatency.bench.ts",
     "benchmark:storage-overhead": "vitest bench --watch=false tests/benchmarks/StorageOverhead.bench.ts",
@@ -33,10 +35,12 @@
   "devDependencies": {
     "@eslint/js": "latest",
     "@playwright/test": "latest",
+    "@vitest/coverage-v8": "latest",
     "@webgpu/types": "latest",
     "electron": "latest",
     "eslint": "latest",
     "fake-indexeddb": "latest",
+    "husky": "latest",
     "typescript": "latest",
     "typescript-eslint": "latest",
     "vitest": "latest"

package.json

@@ -31,8 +31,11 @@ const IGNORED_DIRS = new Set([
   "tests",
 ]);
 
-/** The only file allowed to define raw numeric hotpath policy constants. */
-const ALLOWED_SOURCE_FILE = "core/HotpathPolicy.ts";
+/** The only file(s) allowed to define raw numeric hotpath policy constants. */
+const ALLOWED_SOURCE_FILES = new Set([
+  "core/HotpathPolicy.ts",
+  "lib/core/HotpathPolicy.ts",
+]);
 
 /**
  * Field names that must not receive hardcoded numeric literals outside the
@@ -108,7 +111,7 @@ async function main() {
   const violations = [];
 
   for (const relativePath of tsFiles) {
-    if (relativePath === ALLOWED_SOURCE_FILE) {
+    if (ALLOWED_SOURCE_FILES.has(relativePath)) {
       continue;
     }
 

scripts/guard-hotpath-policy.mjs

@@ -15,8 +15,12 @@ const IGNORED_DIRS = new Set([
 ]);
 
 const ALLOWED_SOURCE_FILES = new Set([
+  // These files are the canonical source of model-derived numeric constants.
+  // They are explicitly allowed to contain hardcoded model profile values.
   "core/ModelDefaults.ts",
   "core/BuiltInModelProfiles.ts",
+  "lib/core/ModelDefaults.ts",
+  "lib/core/BuiltInModelProfiles.ts",
 ]);
 
 const MODEL_FIELD_PATTERN =

scripts/guard-model-derived.mjs

@@ -0,0 +1,46 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  test: {
+    include: ["**/*.test.ts", "**/*.spec.ts"],
+    coverage: {
+      provider: "v8",
+      enabled: !!process.env.CI,
+      clean: true,
+      include: ["lib/**/*.ts"],
+      reporter: ["text", "html"],
+      reportsDirectory: "coverage",
+      exclude: [
+        // Runtime configuration + platform-specific code that is not testable in this environment
+        "lib/CreateVectorBackend.ts",
+        "lib/WasmVectorBackend.ts",
+        "lib/WebGLVectorBackend.ts",
+        "lib/WebGPUVectorBackend.ts",
+        "lib/WebNNVectorBackend.ts",
+        // Pure type definitions (no executable JS generated)
+        "**/*.d.ts",
+        "**/types.ts",
+        "**/VectorBackend.ts",
+        "**/ModelProfile.ts",
+        "**/QueryResult.ts",
+        "**/WebNNTypes.*",
+        // Test and tooling files
+        "tests/**",
+        "benchmarks/**",
+        "scripts/**",
+        "docker/**",
+        "node_modules/**",
+      ],
+      thresholds: {
+        // Enforce a minimum test coverage baseline. We focus on line/statement/function
+        // coverage; branch coverage is tracked but may vary substantially across
+        // complex control flows (e.g., optional platform APIs). Adjust this if we
+        // decide to enforce strict branch coverage in the future.
+        lines: 80,
+        functions: 80,
+        branches: 0,
+        statements: 80,
+      },
+    },
+  },
+});