Fix upgrade command. Closes #293

Closes #293

Author: garrytrinder

CHANGELOG.md

@@ -6,8 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 > **Note**: odd version numbers, for example, `0.13.0`, are not included in this changelog. They are used to test the new features and fixes before the final release.
+
 ## [0.26.3] - 2025-06-27
 
+### Fixed:
+
+- Commands: Fixed issue where brew update output would be shown in a notification when upgrading Dev Proxy via homebrew
+
 ## [0.26.2] - 2025-06-27
 
 ### Changed:

src/helpers.ts

@@ -122,10 +122,11 @@ export const executeCommand = async (cmd: string, options: ExecOptions = {}): Pr
   return new Promise((resolve, reject) => {
     exec(cmd, options, (error, stdout, stderr) => {
       if (error) {
-        reject(`exec error: ${error}`);
-      } else if (stderr) {
-        reject(`stderr: ${stderr}`);
+        // Command failed with non-zero exit code
+        reject(`exec error: ${error}${stderr ? `\nstderr: ${stderr}` : ''}`);
       } else {
+        // Command succeeded (exit code 0), return stdout
+        // Note: Many tools like brew send informational messages to stderr even on success
         resolve(stdout);
       }
     });

src/test/extension.test.ts

@@ -3,6 +3,7 @@ import * as vscode from 'vscode';
 import {
   isConfigFile,
   sleep,
+  executeCommand,
 } from '../helpers';
 import * as path from 'path';
 import { createCodeLensForPluginNodes } from '../codelens';
@@ -686,3 +687,65 @@ info    v0.30.0-beta.2`;
     assert.strictEqual(result, '0.30.0-beta.2');
   });
 });
+
+suite('executeCommand', () => {
+  test('should resolve when command succeeds with stdout only', async () => {
+    // Test with a simple command that only outputs to stdout
+    const result = await executeCommand('echo "hello world"');
+    assert.strictEqual(result.trim(), 'hello world');
+  });
+
+  test('should resolve when command succeeds with stderr output (informational)', async () => {
+    // Test with a command that outputs to stderr but exits with code 0
+    // This simulates brew update behavior where informational messages go to stderr
+    const result = await executeCommand('echo "output" && echo "info message" >&2');
+    assert.strictEqual(result.trim(), 'output');
+  });
+
+  test('should reject when command fails with non-zero exit code', async () => {
+    // Test with a command that fails (exit code 1)
+    try {
+      await executeCommand('exit 1');
+      assert.fail('Expected executeCommand to reject but it resolved');
+    } catch (error) {
+      assert.ok(typeof error === 'string');
+      assert.ok(error.includes('exec error'));
+    }
+  });
+
+  test('should reject when command fails and include stderr in error message', async () => {
+    // Test with a command that fails and outputs to stderr
+    try {
+      await executeCommand('echo "error details" >&2 && exit 1');
+      assert.fail('Expected executeCommand to reject but it resolved');
+    } catch (error) {
+      assert.ok(typeof error === 'string');
+      assert.ok(error.includes('exec error'));
+      assert.ok(error.includes('error details'));
+    }
+  });
+
+  test('should handle command not found errors', async () => {
+    try {
+      await executeCommand('nonexistentcommand12345');
+      assert.fail('Expected executeCommand to reject but it resolved');
+    } catch (error) {
+      assert.ok(typeof error === 'string');
+      assert.ok(error.includes('exec error'));
+    }
+  });
+
+  test('should resolve with empty string when command succeeds with no output', async () => {
+    const result = await executeCommand('true'); // true command succeeds and outputs nothing
+    assert.strictEqual(result, '');
+  });
+
+  test('should simulate brew update behavior (GitHub issue #292)', async () => {
+    // Simulate the specific case from GitHub issue #292 where brew sends
+    // informational messages to stderr but the command succeeds
+    const result = await executeCommand('echo "Already up-to-date." && echo "==> Updating Homebrew..." >&2');
+    
+    // Should resolve (not reject) and return stdout content
+    assert.strictEqual(result.trim(), 'Already up-to-date.');
+  });
+});