[BUG] window-command not working under Wayland (niri)

[Lodifice]

Rofi version (rofi -v or git commit in case of build issue)

2.0.0

Configuration

https://gist.github.com/Lodifice/ed1ac229644f9d05717030027d214c40

Theme

https://gist.github.com/Lodifice/dcea5f9f08e8e4fb4bd28fbb0ff35a7e

Timing report

No response

Launch command

rofi -show window -mode window -window-command "notify-send rofi {window}"

Step to reproduce

Just run the launch command from a terminal (optionally skip -window-command since it is also in the config). Then press Shift+Enter on any entry.

Expected behavior

A notification pops up.

Actual behavior

The window manager (niri) switches to the selected window.

Additional information

I've tried different commands and different key bindings for kb-accept-alt. It's always the same, as if the normal accept was hit. However, under Xorg (dwm) it works as intended.

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[lbonn]

See also the initial PR for wayland window mode: lbonn#58.

It was not done yet because we don't have an equivalent to the window id in X11 in this case, so it's less useful to compose with other tools and the place-holders for formatting the commands should be reworked and probably diverge between the two backends.

[Lodifice]

Thanks for the pointer. So there is no concept of window id in wayland, but many compositors still use this concept. E.g. in niri window ids can be easily obtained by niri msg windows. Wouldn't it be possible to incorporate this into the place-holder?

I must admit that I have no idea how rofi queries the compositor for the list of windows. If that's a general compositor-transparent way that just doesn't expose window ids, then I'd assume would unfeasible to add a specific way to obtain the window ids for every particular compositor.