Skip to content

Commit 0b0cd7e

Browse files
committed
refactor: update ContactSpec fields to optional
1 parent 07b91cb commit 0b0cd7e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

config/crd/bases/notification/notification.miloapis.com_contacts.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ spec:
9191
type: object
9292
required:
9393
- email
94-
- familyName
95-
- givenName
9694
type: object
9795
status:
9896
properties:

docs/api/notification.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -857,14 +857,14 @@ ContactSpec defines the desired state of Contact.
857857
<td>
858858
<br/>
859859
</td>
860-
<td>true</td>
860+
<td>false</td>
861861
</tr><tr>
862862
<td><b>givenName</b></td>
863863
<td>string</td>
864864
<td>
865865
<br/>
866866
</td>
867-
<td>true</td>
867+
<td>false</td>
868868
</tr><tr>
869869
<td><b><a href="#contactspecsubject">subject</a></b></td>
870870
<td>object</td>

pkg/apis/notification/v1alpha1/contact_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ type ContactSpec struct {
6161
// +kubebuilder:validation:Optional
6262
SubjectRef *SubjectReference `json:"subject,omitempty"`
6363

64-
// +kubebuilder:validation:Required
64+
// +kubebuilder:validation:Optional
6565
FamilyName string `json:"familyName,omitempty"`
6666

67-
// +kubebuilder:validation:Required
67+
// +kubebuilder:validation:Optional
6868
GivenName string `json:"givenName,omitempty"`
6969

7070
// +kubebuilder:validation:Required

0 commit comments

Comments
 (0)