feat: Improved validatePackage function (fixed bugs, added FK validation) (#179)

* Added fixture

* Added test

* Added concatFileStreams

* Support multipart path in validateFile

* Added aliases validateResource/PackageMetadata

* Don't rais if can't load a table

* Added encoding validation

* Fixed test

* Improved error message

* Fixed polars encoding

* Fixed fixture for issue #153

* Updated test

* Fixed type erors

* Fixed validateFile spec

* Fixed inferFile spec

* Fixed validateResourceCommand spec

* Enable failing test

* Fixed missing values being considered cell/type errors

* Fixed cell/type-required duplication

Author: roll

cli/commands/resource/validate.spec.ts

@@ -9,9 +9,10 @@ useRecording()
 
 describe("resource validate", () => {
   it("should validate a valid resource", async () => {
+    const csvPath = await writeTempFile("id,name\n1,alice\n2,bob")
     const resourceContent = JSON.stringify({
       name: "test-resource",
-      path: "data.csv",
+      path: basename(csvPath),
     })
     const resourcePath = await writeTempFile(resourceContent)
 

cli/commands/schema/infer.tsx

@@ -79,14 +79,19 @@ export const inferSchemaCommand = new Command("infer")
       loadTable(resource, { denormalized: true }),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     const inferredSchema = await session.task(
       "Inferring schema",
       inferSchemaFromTable(table, options),
     )
 
     if (isEmptyObject(inferredSchema)) {
       session.terminate("Could not infer schema")
-      process.exit(1) // typescript ignore never return type above
+      process.exit(1)
     }
 
     await session.render(inferredSchema, <SchemaGrid schema={inferredSchema} />)

cli/commands/table/convert.tsx

@@ -142,6 +142,11 @@ export const convertTableCommand = new Command("convert")
       loadTable(resource, options),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     if (options.query) {
       table = queryTable(table, options.query)
     }

cli/commands/table/describe.tsx

@@ -93,6 +93,11 @@ export const describeTableCommand = new Command("describe")
       loadTable(resource, options),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     if (options.query) {
       table = queryTable(table, options.query)
     }

cli/commands/table/explore.tsx

@@ -92,6 +92,11 @@ export const exploreTableCommand = new Command("explore")
       loadTable(resource, { denormalized: true }),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     if (!schema && resource.schema) {
       schema = await session.task(
         "Loading schema",

cli/commands/table/script.tsx

@@ -94,6 +94,11 @@ export const scriptTableCommand = new Command("script")
       loadTable(resource, options),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     if (options.query) {
       table = queryTable(table, options.query)
     }

cli/commands/table/validate.tsx

@@ -99,6 +99,11 @@ export const validateTableCommand = new Command("validate")
       loadTable(resource, { denormalized: true }),
     )
 
+    if (!table) {
+      session.terminate("Could not load table")
+      process.exit(1)
+    }
+
     if (!schema && resource.schema) {
       schema = await session.task(
         "Loading schema",

cloud/components/Report/Error/Error.tsx

@@ -14,7 +14,7 @@ import {
 } from "./Cell.tsx"
 import { FieldNameError, FieldTypeError } from "./Field.tsx"
 import { FieldsExtraError, FieldsMissingError } from "./Fields.tsx"
-import { BytesError, HashError } from "./File.tsx"
+import { BytesError, EncodingError, HashError } from "./File.tsx"
 import { MetadataError } from "./Metadata.tsx"
 import { RowUniqueError } from "./Row.tsx"
 
@@ -31,6 +31,8 @@ export function Error(props: {
       return <BytesError error={error} />
     case "file/hash":
       return <HashError error={error} />
+    case "file/encoding":
+      return <EncodingError error={error} />
     case "fields/missing":
       return <FieldsMissingError error={error} />
     case "fields/extra":

cloud/components/Report/Error/File.tsx

@@ -35,3 +35,20 @@ export function HashError(props: { error: errorTypes.HashError }) {
     </Text>
   )
 }
+
+export function EncodingError(props: { error: errorTypes.EncodingError }) {
+  const { t } = useTranslation()
+
+  return (
+    <Text>
+      {t("File encoding")} {t("is expected to be")}{" "}
+      <Code fz="lg" fw="bold">
+        {props.error.encoding}
+      </Code>{" "}
+      {t("but it is actually")}{" "}
+      <Code fz="lg" fw="bold">
+        {props.error.actualEncoding}
+      </Code>
+    </Text>
+  )
+}

cloud/locales/de.json

@@ -51,6 +51,7 @@
   "are not expected": "werden nicht erwartet",
   "File size": "Dateigröße",
   "File hash": "Datei-Hash",
+  "File encoding": "Datei-Kodierung",
   "Field name": "Feldname",
   "at": "bei",
   "The cell values of the fields": "Die Zellwerte der Felder",