Merge pull request #83 from dataiku/chore/accept-percent-encoded-space-in-root-overwrite

Accept percent encoded space in root overwrite

Author: alexbourret

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [Version 1.1.10](https://github.com/dataiku/dss-plugin-sharepoint-online/releases/tag/v1.1.10) - Patch release - 2025-10-04
+
+- Add legacy mode to accept percent encoded spaces ("%20") in root directory preset overwrite
+
 ## [Version 1.1.9](https://github.com/dataiku/dss-plugin-sharepoint-online/releases/tag/v1.1.9) - Bugfix release - 2025-09-23
 
 - Fix handling of username / password error message

plugin.json

@@ -1,18 +1,28 @@
 {
     "id": "sharepoint-online",
-    "version": "1.1.9",
+    "version": "1.1.10",
     "meta": {
         "label": "SharePoint Online",
         "description": "Read and write data from/to your SharePoint Online account",
         "author": "Dataiku (Alex Bourret)",
         "icon": "icon-cloud",
+        "category": "Connect",
         "tags": [
-            "Connector",
-            "Cloud",
-            "Azure",
-            "Format"
+            "Data source",
+            "Export",
+            "Recipe",
+            "Dataset"
         ],
         "url": "https://www.dataiku.com/product/plugins/sharepoint-online/",
         "licenseInfo": "Apache Software License"
-    }
+    },
+    "params": [
+        {
+            "name": "root_name_overwrite_legacy_mode",
+            "label": "Legacy mode",
+            "description": "Treat %20 as spaces in root directory preset overwrite",
+            "type": "BOOLEAN",
+            "defaultValue": false
+        }
+    ]
 }

python-fs-providers/sharepoint-online_shared-documents/fs-provider.py

@@ -32,8 +32,11 @@ def __init__(self, root, config, plugin_config):
         self.provider_root = "/"
         logger.info('SharePoint Online plugin fs v{}'.format(DSSConstants.PLUGIN_VERSION))
         logger.info('init:root={}'.format(self.root))
-
-        self.client = SharePointClient(config)
+        root_name_overwrite_legacy_mode = plugin_config.get("root_name_overwrite_legacy_mode", False)
+        self.client = SharePointClient(
+            config,
+            root_name_overwrite_legacy_mode=root_name_overwrite_legacy_mode
+        )
 
     # util methods
     def get_full_path(self, path):

python-lib/dss_constants.py

@@ -38,7 +38,7 @@ class DSSConstants(object):
         "sharepoint_oauth": "The access token is missing"
     }
     PATH = 'path'
-    PLUGIN_VERSION = "1.1.9"
+    PLUGIN_VERSION = "1.1.10"
     SECRET_PARAMETERS_KEYS = ["Authorization", "sharepoint_username", "sharepoint_password", "client_secret", "client_certificate", "passphrase"]
     SITE_APP_DETAILS = {
         "sharepoint_tenant": "The tenant name is missing",

python-lib/sharepoint_client.py

@@ -32,8 +32,9 @@ class SharePointClientError(ValueError):
 
 class SharePointClient():
 
-    def __init__(self, config):
+    def __init__(self, config, root_name_overwrite_legacy_mode=False):
         self.config = config
+        self.root_name_overwrite_legacy_mode = root_name_overwrite_legacy_mode
         self.sharepoint_root = None
         self.sharepoint_url = None
         self.sharepoint_origin = None
@@ -183,6 +184,8 @@ def setup_login_details(self, login_details):
     def apply_paths_overwrite(self, config):
         advanced_parameters = config.get("advanced_parameters", False)
         sharepoint_root_overwrite = config.get("sharepoint_root_overwrite", "").strip("/")
+        if self.root_name_overwrite_legacy_mode:
+            sharepoint_root_overwrite = sharepoint_root_overwrite.replace("%20", " ")
         sharepoint_site_overwrite = config.get("sharepoint_site_overwrite", "").strip("/")
         if advanced_parameters and sharepoint_root_overwrite:
             self.sharepoint_root = sharepoint_root_overwrite