Commit e0ef2e7
authored
Add VARIANT type to ColumnInfoTypeName for correct SEA metadata (#1388)
## Summary
- VARIANT columns in the SEA path returned `null` for
`getColumnClassName()` because `ColumnInfoTypeName` had no `VARIANT`
enum value, causing Jackson deserialization to fail silently
- Added `VARIANT` to the enum and all relevant type mapping methods
(`getColumnInfoType`, `getColumnType`, `getColumnTypeClassName`) so both
SEA and Thrift paths return consistent metadata (`java.lang.String`,
`Types.OTHER`)
- Added test coverage for all new VARIANT mappings
## Test plan
- [x] `DatabricksTypeUtilTest` — 59 tests pass (includes new VARIANT
assertions in `testGetColumnType`, `testGetColumnTypeClassName`,
`testGetColumnInfoType`, `testIsSigned`)
- [x] `DatabricksResultSetMetaDataTest` — 28 tests pass
- [x] E2E verification: ran `example_run_variant` against live workspace
— both THRIFT and SEA return `ColumnClassName=java.lang.String,
ColumnTypeName=VARIANT`
This pull request was AI-assisted by Isaac.
---------
Signed-off-by: Sreekanth Vadigi <[email protected]>1 parent f2f57ec commit e0ef2e7
File tree
4 files changed
+13
-3
lines changed- src
- main/java/com/databricks/jdbc
- common/util
- model/core
- test/java/com/databricks/jdbc/common/util
4 files changed
+13
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
| 120 | + | |
119 | 121 | | |
120 | 122 | | |
121 | 123 | | |
| |||
163 | 165 | | |
164 | 166 | | |
165 | 167 | | |
| 168 | + | |
166 | 169 | | |
167 | 170 | | |
168 | 171 | | |
| |||
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
| 209 | + | |
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
135 | | - | |
| 136 | + | |
| 137 | + | |
136 | 138 | | |
137 | 139 | | |
138 | 140 | | |
| |||
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
| 196 | + | |
194 | 197 | | |
195 | 198 | | |
196 | 199 | | |
| |||
285 | 288 | | |
286 | 289 | | |
287 | 290 | | |
| 291 | + | |
288 | 292 | | |
289 | 293 | | |
290 | 294 | | |
| |||
0 commit comments