Read plugin-owned paths from manifest during the apps init

Author: pkosiec

cmd/apps/init.go

@@ -794,7 +794,7 @@ func runCreate(ctx context.Context, opts createOptions) error {
 
 	// Apply plugin-specific post-processing (e.g., remove config/queries if analytics not selected)
 	runErr = prompt.RunWithSpinnerCtx(ctx, "Configuring plugins...", func() error {
-		return applyPlugins(absOutputDir, selectedPlugins)
+		return applyPlugins(absOutputDir, selectedPlugins, m.GetTemplatePaths())
 	})
 	if runErr != nil {
 		return runErr
@@ -946,20 +946,14 @@ func buildPluginStrings(pluginNames []string) (pluginImport, pluginUsage string)
 	return pluginImport, pluginUsage
 }
 
-// pluginOwnedPaths maps plugin names to directories they own.
-// When a plugin is not selected, its owned paths are removed from the project.
-var pluginOwnedPaths = map[string][]string{
-	"analytics": {"config/queries"},
-}
-
-// applyPlugins removes directories owned by unselected plugins.
-func applyPlugins(projectDir string, pluginNames []string) error {
+// applyPlugins removes template directories owned by unselected plugins.
+func applyPlugins(projectDir string, pluginNames []string, templatePaths map[string][]string) error {
 	selectedSet := make(map[string]bool)
 	for _, name := range pluginNames {
 		selectedSet[name] = true
 	}
 
-	for plugin, paths := range pluginOwnedPaths {
+	for plugin, paths := range templatePaths {
 		if selectedSet[plugin] {
 			continue
 		}

cmd/apps/init_test.go

@@ -458,6 +458,59 @@ func TestAppendUniqueNoValues(t *testing.T) {
 	assert.Equal(t, []string{"a", "b"}, result)
 }
 
+func TestApplyPlugins(t *testing.T) {
+	tests := []struct {
+		name          string
+		selected      []string
+		templatePaths map[string][]string
+		expectRemoved []string
+		expectKept    []string
+	}{
+		{
+			name:          "unselected plugin directory is removed",
+			selected:      []string{"server"},
+			templatePaths: map[string][]string{"analytics": {"config/queries"}},
+			expectRemoved: []string{"config/queries"},
+		},
+		{
+			name:          "selected plugin directory is kept",
+			selected:      []string{"analytics", "server"},
+			templatePaths: map[string][]string{"analytics": {"config/queries"}},
+			expectKept:    []string{"config/queries"},
+		},
+		{
+			name:          "empty templatePaths is a no-op",
+			selected:      []string{"server"},
+			templatePaths: map[string][]string{},
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			dir := t.TempDir()
+
+			// Create all directories referenced in templatePaths
+			for _, paths := range tc.templatePaths {
+				for _, p := range paths {
+					require.NoError(t, os.MkdirAll(filepath.Join(dir, p), 0o755))
+				}
+			}
+
+			err := applyPlugins(dir, tc.selected, tc.templatePaths)
+			require.NoError(t, err)
+
+			for _, p := range tc.expectRemoved {
+				_, statErr := os.Stat(filepath.Join(dir, p))
+				assert.True(t, os.IsNotExist(statErr), "expected %s to be removed", p)
+			}
+			for _, p := range tc.expectKept {
+				_, statErr := os.Stat(filepath.Join(dir, p))
+				assert.NoError(t, statErr, "expected %s to exist", p)
+			}
+		})
+	}
+}
+
 func TestRunManifestOnlyFound(t *testing.T) {
 	dir := t.TempDir()
 	manifestPath := filepath.Join(dir, manifest.ManifestFileName)

libs/apps/manifest/manifest.go

@@ -67,6 +67,7 @@ type Plugin struct {
 	Description        string    `json:"description"`
 	Package            string    `json:"package"`
 	RequiredByTemplate bool      `json:"requiredByTemplate"`
+	TemplatePaths      []string  `json:"templatePaths,omitempty"`
 	Resources          Resources `json:"resources"`
 }
 
@@ -205,6 +206,18 @@ func (m *Manifest) CollectResources(pluginNames []string) []Resource {
 	return resources
 }
 
+// GetTemplatePaths returns a map of plugin name to template directory paths.
+// Only plugins that declare at least one path are included.
+func (m *Manifest) GetTemplatePaths() map[string][]string {
+	result := make(map[string][]string)
+	for name, p := range m.Plugins {
+		if len(p.TemplatePaths) > 0 {
+			result[name] = p.TemplatePaths
+		}
+	}
+	return result
+}
+
 // CollectOptionalResources returns all optional resources for the given plugin names.
 func (m *Manifest) CollectOptionalResources(pluginNames []string) []Resource {
 	seen := make(map[string]bool)

libs/apps/manifest/manifest_test.go

@@ -320,6 +320,34 @@ func TestResourceKey(t *testing.T) {
 	assert.Equal(t, "sql_warehouse", r.VarPrefix())
 }
 
+func TestGetTemplatePaths(t *testing.T) {
+	m := &manifest.Manifest{
+		Plugins: map[string]manifest.Plugin{
+			"analytics": {
+				Name:          "analytics",
+				TemplatePaths: []string{"config/queries"},
+			},
+			"server": {
+				Name: "server",
+			},
+		},
+	}
+
+	paths := m.GetTemplatePaths()
+	assert.Equal(t, map[string][]string{"analytics": {"config/queries"}}, paths)
+}
+
+func TestGetTemplatePathsEmpty(t *testing.T) {
+	m := &manifest.Manifest{
+		Plugins: map[string]manifest.Plugin{
+			"server": {Name: "server"},
+		},
+	}
+
+	paths := m.GetTemplatePaths()
+	assert.Empty(t, paths)
+}
+
 func TestCollectOptionalResources(t *testing.T) {
 	m := &manifest.Manifest{
 		Plugins: map[string]manifest.Plugin{