Skip to content

Commit f19b2be

Browse files
committed
show a message about ignoring errors to post to coveralls.io service
(neither that nor the weigh-in.sh thingy have worked for a while, but they’re danvk’s so keeping them in harmlessly)
1 parent 37c4b0b commit f19b2be

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

scripts/generate-coverage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ phantomjs \
5454
http://localhost:8082/auto_tests/coverage.html \
5555
spec '{"hooks": "mocha-phantomjs-istanbul", "coverageFile": "coverage/coverage.json"}'
5656

57-
if [ $CI ]; then
57+
if test -n "$CI"; then
5858
# Convert the JSON coverage to LCOV for coveralls.
5959
istanbul report --include coverage/*.json lcovonly
6060

scripts/post-coverage.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
# comment the line out to post
55
#exit 0
66

7-
if [ $CI ]; then
8-
<coverage/lcov.info ./node_modules/.bin/coveralls
7+
if test -n "$CI"; then
8+
<coverage/lcov.info ./node_modules/.bin/coveralls || \
9+
echo "N: above errors posting to coveralls.io are ignored"
910
fi
1011

1112
true # reset exit code -- failure to post coverage shouldn't be an error.

0 commit comments

Comments
 (0)