Use the result type 'ambiguous' for ambiguous step matches.

Cucumber-Messages has a separate test step result status 'AMBIGUOUS',
therefore cucumber-ruby should use the test result type 'ambiguous'
for ambiguous step matches.

Author: brasmusson

features/docs/defining_steps/ambiguous_steps.feature

@@ -40,14 +40,14 @@ Feature: Ambiguous Steps
           features/step_definitions.rb:5:in `/^an ambiguous step$/'
 
           You can run again with --guess to make Cucumber be more smart about it
-           (Cucumber::Ambiguous)
+           (Cucumber::Core::Test::Result::Ambiguous)
           features/ambiguous.feature:5:in `an ambiguous step'
 
-    Failing Scenarios:
+    Ambiguous Scenarios:
     cucumber features/ambiguous.feature:3 # Scenario:
 
-    1 scenario (1 failed)
-    2 steps (1 failed, 1 passed)
+    1 scenario (1 ambiguous)
+    2 steps (1 ambiguous, 1 passed)
     0m0.012s
 
     """

lib/cucumber/formatter/ansicolor.rb

@@ -47,6 +47,8 @@ module Formatter
     # * <tt>flaky_param</tt>   - defaults to <tt>yellow,bold</tt>
     # * <tt>failed</tt>        - defaults to <tt>red</tt>
     # * <tt>failed_param</tt>  - defaults to <tt>red,bold</tt>
+    # * <tt>ambiguous</tt>     - defaults to <tt>red</tt>
+    # * <tt>abmiguous_param</tt> - defaults to <tt>red,bold</tt>
     # * <tt>passed</tt>        - defaults to <tt>green</tt>
     # * <tt>passed_param</tt>  - defaults to <tt>green,bold</tt>
     # * <tt>outline</tt>       - defaults to <tt>cyan</tt>
@@ -72,6 +74,7 @@ module ANSIColor
         'pending' => 'yellow',
         'flaky' => 'yellow',
         'failed' => 'red',
+        'ambiguous' => 'red',
         'passed' => 'green',
         'outline' => 'cyan',
         'skipped' => 'cyan',

lib/cucumber/formatter/duration_extractor.rb

@@ -14,6 +14,8 @@ def passed(*) end
 
       def failed(*) end
 
+      def ambiguous(*) end
+
       def undefined(*) end
 
       def skipped(*) end

lib/cucumber/formatter/junit.rb

@@ -131,7 +131,7 @@ def create_output_string(test_case, scenario, result, row_name)
       end
 
       def build_testcase(result, scenario_designation, output)
-        duration = ResultBuilder.new(result).test_case_duration
+        duration = DurationExtractor.new(result).result_duration
         @current_feature_data[:time] += duration
         classname = @current_feature_data[:feature].name
         filename = @current_feature_data[:uri]
@@ -234,32 +234,5 @@ def examples_table_row(row)
         @name_suffix = " (outline example : #{@row_name})"
       end
     end
-
-    class ResultBuilder
-      attr_reader :test_case_duration
-
-      def initialize(result)
-        @test_case_duration = 0
-        result.describe_to(self)
-      end
-
-      def passed(*) end
-
-      def failed(*) end
-
-      def undefined(*) end
-
-      def skipped(*) end
-
-      def pending(*) end
-
-      def exception(*) end
-
-      def duration(duration, *)
-        duration.tap { |dur| @test_case_duration = dur.nanoseconds / 10**9.0 }
-      end
-
-      def attach(*) end
-    end
   end
 end

lib/cucumber/formatter/progress.rb

@@ -94,6 +94,7 @@ def print_summary
       CHARS = {
         passed: '.',
         failed: 'F',
+        ambiguous: 'A',
         undefined: 'U',
         pending: 'P',
         skipped: '-'

lib/cucumber/step_match.rb

@@ -148,7 +148,7 @@ def initialize(error)
     end
 
     def activate(test_step)
-      test_step.with_action { raise @error }
+      test_step.with_action { raise Core::Test::Result::Ambiguous, @error.message }
     end
   end
 end