Corrupted images when imagor-process-concurrency > 1

[jrudolph]

We are seeing broken files with high likelihood when concurrency is involved. The symptoms are:

• http source, no storage or result storage
• result files partly contain garbage (see below), though not always starting at the exact same spot
• no errors or other indications in the log (also with debug)
• broken file gets uploaded to result storage
• does not depend on output file type (webp, jpeg, png) all look similar
• timeouts do not matter (in fact, not sure they work at all?)
• the source files can be quite large (e.g. 20000x20000 or larger)

Interestingly:

• when I use an s3-storage (i.e. mirror for the source images), images that end up broken do not end up on the s3 mirror
• when I use local file-storage as a source mirror the problem seems to disappear

So maybe there's some kind of problem of how source input buffers are handled?

[cshum]

@jrudolph would you like to try the docker build at master branch and see if the fix applies?

https://github.com/cshum/imagor/pkgs/container/imagor/667816642?tag=master

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove the stale label or add a comment, or this issue will be closed in 15 days. You can always re-open if you still feel this is still an issue. Tag @cshum for more information.