Skip to content

Commit 06a937a

Browse files
committed
improve handling of --quarter option
1 parent 51f9e5f commit 06a937a

File tree

4 files changed

+27
-5
lines changed

4 files changed

+27
-5
lines changed

scripts/2-process/gcs_process.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def parse_arguments():
4444
"""
4545
Parse command-line options, returns parsed argument namespace.
4646
"""
47+
global QUARTER
4748
LOGGER.info("Parsing command-line options")
4849
parser = argparse.ArgumentParser(description=__doc__)
4950
parser.add_argument(
@@ -70,8 +71,12 @@ def parse_arguments():
7071
if not args.enable_save and args.enable_git:
7172
parser.error("--enable-git requires --enable-save")
7273
if args.quarter != QUARTER:
73-
global PATHS
74+
global FILE_PATHS, PATHS
75+
FILE_PATHS = shared.paths_list_update(
76+
LOGGER, FILE_PATHS, QUARTER, args.quarter
77+
)
7478
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
79+
QUARTER = args.quarter
7580
args.logger = LOGGER
7681
args.paths = PATHS
7782
return args

scripts/2-process/github_process.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def parse_arguments():
3434
"""
3535
Parse command-line options, returns parsed argument namespace.
3636
"""
37+
global QUARTER
3738
LOGGER.info("Parsing command-line options")
3839
parser = argparse.ArgumentParser(description=__doc__)
3940
parser.add_argument(
@@ -62,8 +63,12 @@ def parse_arguments():
6263
if not args.enable_save and args.enable_git:
6364
parser.error("--enable-git requires --enable-save")
6465
if args.quarter != QUARTER:
65-
global PATHS
66+
global FILE_PATHS, PATHS
67+
FILE_PATHS = shared.paths_list_update(
68+
LOGGER, FILE_PATHS, QUARTER, args.quarter
69+
)
6670
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
71+
QUARTER = args.quarter
6772
args.logger = LOGGER
6873
args.paths = PATHS
6974
return args

scripts/2-process/wikipedia_process.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def parse_arguments():
4545
"""
4646
Parse command-line options, returns parsed argument namespace.
4747
"""
48+
global QUARTER
4849
LOGGER.info("Parsing command-line options")
4950
parser = argparse.ArgumentParser(description=__doc__)
5051
parser.add_argument(
@@ -73,8 +74,12 @@ def parse_arguments():
7374
if not args.enable_save and args.enable_git:
7475
parser.error("--enable-git requires --enable-save")
7576
if args.quarter != QUARTER:
76-
global PATHS
77+
global FILE_PATHS, PATHS
78+
FILE_PATHS = shared.paths_list_update(
79+
LOGGER, FILE_PATHS, QUARTER, args.quarter
80+
)
7781
PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
82+
QUARTER = args.quarter
7883
args.logger = LOGGER
7984
args.paths = PATHS
8085
return args

scripts/shared.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,13 @@ def paths_update(logger, paths, old_quarter, new_quarter):
207207
return paths
208208

209209

210+
def paths_list_update(logger, paths_list, old_quarter, new_quarter):
211+
logger.info(f"Updating paths: replacing {old_quarter} with {new_quarter}")
212+
for index, path in enumerate(paths_list):
213+
paths_list[index] = path.replace(old_quarter, new_quarter)
214+
return paths_list
215+
216+
210217
class ColoredFormatter(logging.Formatter):
211218
"""Adds colors to log messages."""
212219

@@ -301,8 +308,8 @@ def update_readme(
301308
logger = args.logger
302309
paths = args.paths
303310
ordered_sections = section_order()
304-
logger.info(f"ordered_sections:, {ordered_sections}")
305-
logger.info(f"section_title:, {section_title}")
311+
logger.info(f"ordered_sections: {ordered_sections}")
312+
logger.info(f"section_title: {section_title}")
306313

307314
if not args.enable_save:
308315
return

0 commit comments

Comments
 (0)