Open
Conversation
dosubot
bot
added
the
size:XS
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/scripts/install.sh">
<violation number="1" location="extensions/cli/scripts/install.sh:194">
P1: Post-install validation checks the directory instead of the fnm executable, allowing false success when the binary is missing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
The installation script failed to check if fnm binary is installed. closes continuedev#12173 Signed-off-by: Robert Gildein <gildeinrobert@gmail.com>
rgildein
force-pushed
the
bug/install-script
branch
from
e3f533e to
21a2243
Compare
dosubot
bot
added
size:S
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation script failed to check if
fnmbinary is installed.closes: #12173
Description
Installation script was failing to check if
fnmbinary was installed.AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Tests
Just manually tested.
Summary by cubic
Fixes the installer to correctly detect the
fnmbinary and prevent false “binary not found” errors during Node setup. Addresses #12173.fnmwithcommand -v(before and after updating PATH) and only mark cleanup when missing, removing the hardcoded$FNM_INSTALL_DIR/fnmcheck.Written for commit 21a2243. Summary will update on new commits.