Skip to content

Commit a75e836

Browse files
committed
WIP: Test buildah cache-stages changes - DO NOT MERGE
Vendor buildah from ezopezo/buildah@ea82074 and add flag mappings: - BuildIDFile: write build ID to file - CacheStages: preserve intermediate stage images - StageLabels: add metadata labels to stage images This is a testing PR to validate buildah changes work with podman. Signed-off-by: Erik Mravec <[email protected]>
1 parent d220d58 commit a75e836

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+1055
-127
lines changed

cmd/podman/common/build.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,9 +558,11 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *Buil
558558
Args: args,
559559
BlobDirectory: flags.BlobCache,
560560
BuildOutputs: flags.BuildOutputs,
561+
BuildIDFile: flags.BuildIDFile,
561562
CacheFrom: cacheFrom,
562563
CacheTo: cacheTo,
563564
CacheTTL: cacheTTL,
565+
CacheStages: flags.CacheStages,
564566
ConfidentialWorkload: confidentialWorkloadOptions,
565567
CommonBuildOpts: commonOpts,
566568
Compression: compression,
@@ -609,6 +611,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *Buil
609611
SignBy: flags.SignBy,
610612
SignaturePolicyPath: flags.SignaturePolicy,
611613
Squash: flags.Squash,
614+
StageLabels: flags.StageLabels,
612615
SystemContext: systemContext,
613616
Target: flags.Target,
614617
TransientMounts: flags.Volumes,

go.mod

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ require (
6363
github.com/stretchr/testify v1.11.1
6464
github.com/vbauerster/mpb/v8 v8.11.3
6565
github.com/vishvananda/netlink v1.3.1
66-
go.podman.io/common v0.66.2-0.20260126213724-1e46b0756b39
67-
go.podman.io/image/v5 v5.38.1-0.20260123202709-b5801a635dfa
68-
go.podman.io/storage v1.61.1-0.20260123202709-b5801a635dfa
66+
go.podman.io/common v0.66.2-0.20260130150631-28c83ab6f016
67+
go.podman.io/image/v5 v5.38.1-0.20260130150631-28c83ab6f016
68+
go.podman.io/storage v1.61.1-0.20260130150631-28c83ab6f016
6969
golang.org/x/crypto v0.47.0
7070
golang.org/x/net v0.49.0
7171
golang.org/x/sync v0.19.0
@@ -139,8 +139,8 @@ require (
139139
github.com/mistifyio/go-zfs/v4 v4.0.0 // indirect
140140
github.com/moby/buildkit v0.26.3 // indirect
141141
github.com/moby/go-archive v0.1.0 // indirect
142-
github.com/moby/moby/api v1.52.0 // indirect
143-
github.com/moby/moby/client v0.2.1 // indirect
142+
github.com/moby/moby/api v1.53.0 // indirect
143+
github.com/moby/moby/client v0.2.2 // indirect
144144
github.com/moby/patternmatcher v0.6.0 // indirect
145145
github.com/moby/sys/mountinfo v0.7.2 // indirect
146146
github.com/moby/sys/sequential v0.6.0 // indirect
@@ -191,3 +191,5 @@ require (
191191
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
192192
tags.cncf.io/container-device-interface/specs-go v1.1.0 // indirect
193193
)
194+
195+
replace github.com/containers/buildah => github.com/ezopezo/buildah v0.0.0-20260205072956-ea820741f9f9

go.sum

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ github.com/containernetworking/cni v1.3.0 h1:v6EpN8RznAZj9765HhXQrtXgX+ECGebEYEm
5757
github.com/containernetworking/cni v1.3.0/go.mod h1:Bs8glZjjFfGPHMw6hQu82RUgEPNGEaBb9KS5KtNMnJ4=
5858
github.com/containernetworking/plugins v1.9.0 h1:Mg3SXBdRGkdXyFC4lcwr6u2ZB2SDeL6LC3U+QrEANuQ=
5959
github.com/containernetworking/plugins v1.9.0/go.mod h1:JG3BxoJifxxHBhG3hFyxyhid7JgRVBu/wtooGEvWf1c=
60-
github.com/containers/buildah v1.42.1-0.20260126144005-964d45f717ce h1:JNPN3qlLtAZRzggCPK1ffZ4MWuDogG+NtIvQv2bINOY=
61-
github.com/containers/buildah v1.42.1-0.20260126144005-964d45f717ce/go.mod h1:F10eTynOMnjfEzsX8pmZRIJEb5/3+mTEzmRHXB/6+hk=
6260
github.com/containers/common v0.64.2 h1:1xepE7QwQggUXxmyQ1Dbh6Cn0yd7ktk14sN3McSWf5I=
6361
github.com/containers/common v0.64.2/go.mod h1:o29GfYy4tefUuShm8mOn2AiL5Mpzdio+viHI7n24KJ4=
6462
github.com/containers/gvisor-tap-vsock v0.8.7 h1:mFMMU5CIXO9sbtsgECc90loUHx15km3AN6Zuhg3X4qM=
@@ -120,6 +118,8 @@ github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkp
120118
github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
121119
github.com/ebitengine/purego v0.9.1 h1:a/k2f2HQU3Pi399RPW1MOaZyhKJL9w/xFpKAg4q1s0A=
122120
github.com/ebitengine/purego v0.9.1/go.mod h1:iIjxzd6CiRiOG0UyXP+V1+jWqUXVjPKLAI0mRfJZTmQ=
121+
github.com/ezopezo/buildah v0.0.0-20260205072956-ea820741f9f9 h1:8ufXwtDHDyw6BFUwyiHCzdXwAb8xNbbEAJWZTUytFi4=
122+
github.com/ezopezo/buildah v0.0.0-20260205072956-ea820741f9f9/go.mod h1:XLk3MSKCi02sU5t3BIUYJbDV5ci+kNsJzU5NAVZbCow=
123123
github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
124124
github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
125125
github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
@@ -261,10 +261,10 @@ github.com/moby/docker-image-spec v1.3.1 h1:jMKff3w6PgbfSa69GfNg+zN/XLhfXJGnEx3N
261261
github.com/moby/docker-image-spec v1.3.1/go.mod h1:eKmb5VW8vQEh/BAr2yvVNvuiJuY6UIocYsFu/DxxRpo=
262262
github.com/moby/go-archive v0.1.0 h1:Kk/5rdW/g+H8NHdJW2gsXyZ7UnzvJNOy6VKJqueWdcQ=
263263
github.com/moby/go-archive v0.1.0/go.mod h1:G9B+YoujNohJmrIYFBpSd54GTUB4lt9S+xVQvsJyFuo=
264-
github.com/moby/moby/api v1.52.0 h1:00BtlJY4MXkkt84WhUZPRqt5TvPbgig2FZvTbe3igYg=
265-
github.com/moby/moby/api v1.52.0/go.mod h1:8mb+ReTlisw4pS6BRzCMts5M49W5M7bKt1cJy/YbAqc=
266-
github.com/moby/moby/client v0.2.1 h1:1Grh1552mvv6i+sYOdY+xKKVTvzJegcVMhuXocyDz/k=
267-
github.com/moby/moby/client v0.2.1/go.mod h1:O+/tw5d4a1Ha/ZA/tPxIZJapJRUS6LNZ1wiVRxYHyUE=
264+
github.com/moby/moby/api v1.53.0 h1:PihqG1ncw4W+8mZs69jlwGXdaYBeb5brF6BL7mPIS/w=
265+
github.com/moby/moby/api v1.53.0/go.mod h1:8mb+ReTlisw4pS6BRzCMts5M49W5M7bKt1cJy/YbAqc=
266+
github.com/moby/moby/client v0.2.2 h1:Pt4hRMCAIlyjL3cr8M5TrXCwKzguebPAc2do2ur7dEM=
267+
github.com/moby/moby/client v0.2.2/go.mod h1:2EkIPVNCqR05CMIzL1mfA07t0HvVUUOl85pasRz/GmQ=
268268
github.com/moby/patternmatcher v0.6.0 h1:GmP9lR19aU5GqSSFko+5pRqHi+Ohk1O69aFiKkVGiPk=
269269
github.com/moby/patternmatcher v0.6.0/go.mod h1:hDPoyOpDY7OrrMDLaYoY3hf52gNCR/YOUYxkhApJIxc=
270270
github.com/moby/sys/atomicwriter v0.1.0 h1:kw5D/EqkBwsBFi0ss9v1VG3wIkVhzGvLklJ+w3A14Sw=
@@ -445,12 +445,12 @@ go.opentelemetry.io/otel/trace v1.38.0 h1:Fxk5bKrDZJUH+AMyyIXGcFAPah0oRcT+LuNtJr
445445
go.opentelemetry.io/otel/trace v1.38.0/go.mod h1:j1P9ivuFsTceSWe1oY+EeW3sc+Pp42sO++GHkg4wwhs=
446446
go.opentelemetry.io/proto/otlp v1.7.1 h1:gTOMpGDb0WTBOP8JaO72iL3auEZhVmAQg4ipjOVAtj4=
447447
go.opentelemetry.io/proto/otlp v1.7.1/go.mod h1:b2rVh6rfI/s2pHWNlB7ILJcRALpcNDzKhACevjI+ZnE=
448-
go.podman.io/common v0.66.2-0.20260126213724-1e46b0756b39 h1:qMQW6s4s6dmewSyyR5bWWvdGXt9SnRSdXTHiOPvbgcI=
449-
go.podman.io/common v0.66.2-0.20260126213724-1e46b0756b39/go.mod h1:bGauG8nGM+EIHwcCXqhHFCOpdrMZrlap4yrlmNUJs1Y=
450-
go.podman.io/image/v5 v5.38.1-0.20260123202709-b5801a635dfa h1:T/8IVrvcT8N7+1P13Tr1HbAwfa8KQMIMxf2FF9axK8k=
451-
go.podman.io/image/v5 v5.38.1-0.20260123202709-b5801a635dfa/go.mod h1:8wlUZxYaYCtP1IG7eqoy9a4sNULafIV9o4Cj5Jr9Eaw=
452-
go.podman.io/storage v1.61.1-0.20260123202709-b5801a635dfa h1:u/1HgvlgbgV3xngyb8iCSwK55kYI4HwjPVfXCPORJ+s=
453-
go.podman.io/storage v1.61.1-0.20260123202709-b5801a635dfa/go.mod h1:yuLB1ikwsdGrGqSGBWv7fMbOeHupCaMn5iJ1biqxrpI=
448+
go.podman.io/common v0.66.2-0.20260130150631-28c83ab6f016 h1:67MhMHV9Dv484Kc0CldVffhzsNF0Kkacy9xLEmw78XI=
449+
go.podman.io/common v0.66.2-0.20260130150631-28c83ab6f016/go.mod h1:+4bMKfBbfK+qgURkCj6vUtghP5ASjsWyYDI/udLOKxk=
450+
go.podman.io/image/v5 v5.38.1-0.20260130150631-28c83ab6f016 h1:SHPDaE4/lgL/VZYuPkE1hVC4Hclv+gFZpVS3eUFnxgg=
451+
go.podman.io/image/v5 v5.38.1-0.20260130150631-28c83ab6f016/go.mod h1:imQIBRN6114qH01ttrueVkVCHj28jhsiN7Yubh0CzGc=
452+
go.podman.io/storage v1.61.1-0.20260130150631-28c83ab6f016 h1:9/D0XEn1s36LX52GkVfrYA11hOFBCNx/q52CajkEW8A=
453+
go.podman.io/storage v1.61.1-0.20260130150631-28c83ab6f016/go.mod h1:yuLB1ikwsdGrGqSGBWv7fMbOeHupCaMn5iJ1biqxrpI=
454454
go.yaml.in/yaml/v2 v2.4.3 h1:6gvOSjQoTB3vt1l+CU+tSyi/HOjfOjRLJ4YwYZGwRO0=
455455
go.yaml.in/yaml/v2 v2.4.3/go.mod h1:zSxWcmIDjOzPXpjlTTbAsKokqkDNAVtZO0WOMiT90s8=
456456
go.yaml.in/yaml/v3 v3.0.4 h1:tfq32ie2Jv2UxXFdLJdh3jXuOzWiL1fo0bu/FbuKpbc=

vendor/github.com/containers/buildah/define/build.go

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/define/types.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/imagebuildah/executor.go

Lines changed: 47 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)