fix : snappy jump of media detail on launch - #6664
Conversation
|
Any idea why a thin vertical line appears on both your branches? |
Paused your screencast at that point. |
Right now only in this branch , that branch was having that issue ,but now it's separated ! |
It might be because of placeholder of image , before it loads the image , can I investigate and get back to you ? |
Yes, thanks! 🙂 |
#6658. Has no issue and can be merged right ? |
| /** | ||
| * Gets the height of the frame layout as soon as the view is ready and updates aspect ratio | ||
| * of the picture. | ||
| * of the picture and sets visibility of scrollview to prevent jumps. |
There was a problem hiding this comment.
I completely understand this is legacy code.
How about we have shimmer till the image and the data is loaded? Once the data is loaded
- Make the shimmer visibility to gone.
I feel this is a overhead. We can move this to compose if that solves the problem(but no need to do it if it goes out of scope).
Wdyt?
There was a problem hiding this comment.
I won't suggest a compose migration at this point just to solve the snappy jump issue as we usually recommend fixing 5 bugs before picking up enhancements for new contributors.
There was a problem hiding this comment.
@neeldoshii Sure , but can we keep it for later
As @RitikaPahwa4444 said after 5 bug fixes
Right now this will be a workaround
|
@RitikaPahwa4444 changes have been made!!! |
XRecorder_20260301_01.mp4Can you check this @rovertrack ? Upload big image (probably take a screenshot and upload it) and then try to open it. |
| android:cacheColorHint="@android:color/transparent" | ||
| android:fillViewport="true"> | ||
| android:fillViewport="true" | ||
| android:visibility="invisible" |
There was a problem hiding this comment.
Why do we have invisible?
There was a problem hiding this comment.
so that the scroll view is only visible after the spacers height has been adjusted and it doesn't become visible prehand and then jump to bottom after the height adjustment of the spacer
that happened because after uploading the image , it has to be requested again (it is not cached at that time) , so the requesting is taking time and the progress bar is set to gone just after the fragment is placed and not after the image has been loaded from the website |
Nice catch.. Reproduced again. we can create a new issue for this . |
|
@neeldoshii im working on to hide the progress bar only after the image is loaded then we can move ahead with this pr , it will be also helpful when we implement the shimmer effect in the future ) |
I think this is going out of the scope of the current issue, I am merging this PR can you create a new issue addressing about this issue & fix? Thanks @rovertrack |
|
✅ Generated APK variants! |
This reverts commit e272cae.
3 participants
follow up for #6658
Fixes snappy jump caused when launch of media detail
What changes did you make and why?
made the mediaDetailScrollView visible only after the height of the spacer is adjusted (Mediadetailfragment.kt,fragment_media_detail.xml)
Tested betaDebug
oneplus nord
android 12 api level 31
The snappy jump
az_recorder_20260221_034804.mp4
After fix :
az_recorder_20260221_034818.mp4