login: preserve password visibility state on rotation - #6663
Merged
RitikaPahwa4444 merged 2 commits intoFeb 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a login UX issue where the password visibility toggle state is lost after device rotation by persisting and restoring the password field’s visibility state in LoginActivity.
Changes:
- Save password visibility state into
outStateduring configuration changes. - Restore the password visibility (via
transformationMethod) and cursor position inonRestoreInstanceState. - Add a new saved-state key constant for password visibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Saved the password visibility state in onSaveInstanceState and restored it in onRestoreInstanceState to prevent the toggle from resetting to default upon device rotation. Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
Roniscend
force-pushed
the
fix-password-visibility-state
branch
from
February 21, 2026 20:13
7ffcb72 to
97c0fdb
Compare
|
✅ Generated APK variants! |
Collaborator
I thought we're fixing this as well, interesting observation 😄 |
RitikaPahwa4444
approved these changes
Feb 22, 2026
Contributor
Author
I'll create a Separate PR for that |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR resolves the issue where the password visibility toggle resets to its default state after a device rotation. It fixes this by explicitly saving and restoring the password field's transformationMethod in LoginActivity during configuration changes.
Fixes #6662
Tests performed (required)
Tested
betaDebugon Pixel 9 with API level 36 (Android 16).Screenshots (for UI changes only)
https://github.com/user-attachments/assets/6f7654c5-840d-4f38-bbda-f1872a63a506