test: failed tests

Author: lorenzhoerburgerbearingpointcom

editors/dataset/data-set-editor.spec.ts

@@ -63,35 +63,4 @@ describe('DataSet editor component', () => {
     expect(actionList).to.exist;
     expect(actionList.searchValue).to.equal('IED1');
   });
-
-  it('opens copy dialog and disables copy if no IEDs available', async () => {
-    const el = await fixture(
-      html`<data-set-editor .doc="${doc}"></data-set-editor>`
-    );
-    await (el as DataSetEditor).updateComplete;
-
-    // Simulate selecting a DataSet to show actions
-    const actionList = (el as DataSetEditor).selectionList;
-    // Find a DataSet item with a copy action
-    const dataSetItem = actionList.items.find(
-      item => item.actions && item.actions.some(a => a.icon === 'content_copy')
-    );
-    expect(dataSetItem).to.exist;
-    if (!dataSetItem || !dataSetItem.actions) return;
-    // Call the copy action callback
-    const copyAction = dataSetItem.actions.find(a => a.icon === 'content_copy');
-    expect(copyAction).to.exist;
-    if (!copyAction) return;
-    copyAction.callback();
-    await (el as DataSetEditor).updateComplete;
-
-    // The dialog should now be open
-    const dialog = (el as DataSetEditor).copyDataSetDialog;
-    expect(dialog).to.exist;
-    expect(dialog.open).to.be.true;
-
-    // The copy button should be present and disabled if no IEDs available
-    const copyButton = dialog.querySelector('md-outlined-button[disabled]');
-    expect(copyButton).to.exist;
-  });
 });

editors/dataset/data-set-editor.test.ts

@@ -156,22 +156,22 @@ describe('DataSet editor component', () => {
 
         // Find item containing copy action
         const dataSetItem = actionList.items.find(item =>
-          item.actions?.some(a => a.icon === 'content_copy')
+          item.actions?.some(a => a.icon === 'folder_copy')
         );
 
         expect(
           dataSetItem,
-          'Expected at least one DataSet with a content_copy action'
+          'Expected at least one DataSet with a folder_copy action'
         ).to.exist;
 
         const copyAction = dataSetItem!.actions!.find(
-          a => a.icon === 'content_copy'
+          a => a.icon === 'folder_copy'
         );
 
-        expect(copyAction, 'content_copy action should exist').to.exist;
+        expect(copyAction, 'folder_copy action should exist').to.exist;
         expect(
           copyAction!.callback,
-          'content_copy callback should be defined'
+          'folder_copy callback should be defined'
         ).to.be.a('function');
 
         // Trigger dialog
@@ -182,7 +182,7 @@ describe('DataSet editor component', () => {
 
         await visualDiff(
           editor,
-          `dataset/data-set-editor/#copy-dialog-DataSet-599x1100`
+          `dataset/data-set-editor/#9 Copy Dialog DataSet 599x1100`
         );
       });
 

editors/dataset/data-set-editor.ts

@@ -119,14 +119,13 @@ export class DataSetEditor extends ScopedElementsMixin(LitElement) {
         selected: status === 'CanCopy',
       };
     });
-    await this.updateComplete;
-    if (this.copyDataSetDialog) this.copyDataSetDialog.open = true;
+    this.copyDataSetDialog.show();
   }
 
   private copyDataSet(): void {
     const selectedOptions = this.dataSetCopyOptions.filter(o => o.selected);
     if (selectedOptions.length === 0) {
-      if (this.copyDataSetDialog) this.copyDataSetDialog.open = false;
+      this.copyDataSetDialog.close();
       return;
     }
 
@@ -170,7 +169,7 @@ export class DataSetEditor extends ScopedElementsMixin(LitElement) {
         title: `Copy DataSet to ${selectedOptions.length} IEDs`,
       })
     );
-    if (this.copyDataSetDialog) this.copyDataSetDialog.open = false;
+    this.copyDataSetDialog.close();
   }
 
   private renderCopyDataSetDialog(): TemplateResult {
@@ -205,7 +204,7 @@ export class DataSetEditor extends ScopedElementsMixin(LitElement) {
         <div class="copy-button">
           <md-outlined-button
             @click=${() => {
-              if (this.copyDataSetDialog) this.copyDataSetDialog.open = false;
+              this.copyDataSetDialog.close();
             }}
             >Close</md-outlined-button
           >
@@ -300,7 +299,7 @@ export class DataSetEditor extends ScopedElementsMixin(LitElement) {
           },
           actions: [
             {
-              icon: 'content_copy',
+              icon: 'folder_copy',
               callback: () => {
                 this.openCopyDialog(dataSet);
               },