setting up ERB linting (ACTION WILL NOT PASS)

Author: Oaphi

.better-html.yml

@@ -0,0 +1,3 @@
+# https://github.com/Shopify/better-html#configuration
+
+allow_single_quoted_attributes: false

.erb_lint.yml

@@ -0,0 +1,22 @@
+# configuration reference: https://github.com/Shopify/erb_lint?tab=readme-ov-file#configuration
+
+EnableDefaultLinters: false
+
+exclude:
+  - 'config/**/*'
+  - 'db/**/*'
+  - 'scripts/**/*'
+  - 'bin/**/*'
+  - 'lib/namespaced_env_cache.rb'
+  - 'vendor/bundle/**/*'
+glob: '**/*.{html,text,js}{+*,}.erb'
+
+linters:
+  ErbSafety:
+    enabled: true
+    better_html_config: .better-html.yml
+  Rubocop:
+    enabled: true
+    rubocop_config:
+      inherit_from:
+        - .rubocop.yml

.github/workflows/ci-cd.yml

@@ -12,6 +12,28 @@ env:
   RAILS_ENV: test
 
 jobs:
+  erb_lint:
+    name: ERB checking
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby_version: [3.1, 3.2]
+    
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v3
+      - name: Setup dependencies
+        run: |
+          sudo apt-get update -qq
+          sudo apt-get install -yqq libmagickwand-dev
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+      - run: bundle exec erb_lint --lint-all
+
   rubocop:
     name: Rubocop checking
     runs-on: ubuntu-latest
@@ -118,6 +140,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.event_name == 'push' && github.actor != 'dependabot[bot]' }}
     needs:
+      - erb_lint
       - rubocop
       - typescript
       - tests

Gemfile

@@ -51,6 +51,7 @@ gem 'whenever', '~> 1.0', require: false
 
 # Debugging, linting, testing.
 gem 'awesome_print', '~> 1.9'
+gem 'erb_lint', '~> 0.9.0'
 gem 'rubocop', '~> 1'
 gem 'rubocop-rails', '~> 2.15'
 gem 'rubocop-rake', '~> 0.7.1'

Gemfile.lock

@@ -105,6 +105,13 @@ GEM
     base64 (0.3.0)
     bcrypt (3.1.20)
     benchmark (0.4.1)
+    better_html (2.1.1)
+      actionview (>= 6.0)
+      activesupport (>= 6.0)
+      ast (~> 2.0)
+      erubi (~> 1.4)
+      parser (>= 2.4)
+      smart_properties
     bigdecimal (3.2.2)
     bindex (0.8.1)
     builder (3.3.0)
@@ -157,6 +164,13 @@ GEM
     e2mmap (0.1.0)
     erb (4.0.4)
       cgi (>= 0.3.3)
+    erb_lint (0.9.0)
+      activesupport
+      better_html (>= 2.0.1)
+      parser (>= 2.7.1.4)
+      rainbow
+      rubocop (>= 1)
+      smart_properties
     erubi (1.13.1)
     execjs (2.10.0)
     fastimage (2.4.0)
@@ -405,6 +419,7 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
+    smart_properties (1.17.0)
     spring (4.3.0)
     sprockets (4.1.1)
       concurrent-ruby (~> 1.0)
@@ -483,6 +498,7 @@ DEPENDENCIES
   devise_saml_authenticatable (~> 1.9)
   diffy (~> 3.4)
   e2mmap (~> 0.1)
+  erb_lint (~> 0.9.0)
   fastimage (~> 2.2)
   flamegraph (~> 0.9)
   groupdate (~> 6.1)

app/views/admin/create_site.html.erb

@@ -16,4 +16,4 @@
 
 <p>Once you are ready, click on the following button:</p>
 
-<a href="//<%= @new_community.host %>/admin/setup" class="button is-filled is-very-large">To new site</a>
+<a href="//<%= @new_community.host %>/admin/setup" class="button is-filled is-very-large">To new site</a>