-
Notifications
You must be signed in to change notification settings - Fork 4.1k
mma: disk utilization modeling is off #162245
Copy link
Copy link
Closed
Labels
A-kvAnything in KV that doesn't belong in a more specific category.Anything in KV that doesn't belong in a more specific category.A-kv-distributionRelating to rebalancing and leasing.Relating to rebalancing and leasing.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.P-3Issues/test failures with no fix SLAIssues/test failures with no fix SLAT-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-26.1Used to mark GA and release blockers, technical advisories, and bugs for 26.1Used to mark GA and release blockers, technical advisories, and bugs for 26.1target-release-26.1.1target-release-26.2.0v26.1.1v26.2.0-prerelease
Description
Activity
Metadata
Metadata
Assignees
Labels
A-kvAnything in KV that doesn't belong in a more specific category.Anything in KV that doesn't belong in a more specific category.A-kv-distributionRelating to rebalancing and leasing.Relating to rebalancing and leasing.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.P-3Issues/test failures with no fix SLAIssues/test failures with no fix SLAT-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-26.1Used to mark GA and release blockers, technical advisories, and bugs for 26.1Used to mark GA and release blockers, technical advisories, and bugs for 26.1target-release-26.1.1target-release-26.2.0v26.1.1v26.2.0-prerelease
Describe the problem
mma's ByteSize capacity derivation uses filesystem utilization (Capacity - Available) / Capacity to derive a logical capacity. However, this assumes that physical bytes and logical bytes scale proportionally, which is not accurate due to fixed disk overhead (reserved blocks, ballast, other files).
cockroach/pkg/kv/kvserver/mmaintegration/store_load_msg.go
Lines 114 to 123 in 494323e
(Capacity - Available) includes:
These fixed overheads don't scale with LogicalBytes, causing:
Jira issue: CRDB-59337
Epic CRDB-55052